Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Visual Regression Tests / Runner #87

Closed
wants to merge 1 commit into from

Conversation

frank-weindel
Copy link
Collaborator

@frank-weindel frank-weindel commented Nov 20, 2023

Screen Shot 2023-11-20 at 4 53 52 PM

See new / updated READMEs for details on how to run / define / capture snapshots.

I would've used WebKit for the browser, since its the closest to WPE, but I'm unable to get Playwright to work with WebKit at this time. I think for the sake of visual regression (vs actually verifying that a specific browser is rendering correctly) this is fine.

I want to get this all running on GitHub Actions as a PR check. There's a chance we'll have a difference in how things render in the cloud vs our laptops (and even Windows vs Mac vs Linux). Hopefully not, but if so we'll have to figure out how to perhaps distinguish them if necessary.

@frank-weindel
Copy link
Collaborator Author

Replaced by #92 which includes Docker CI mode and GitHub Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant