Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bound calculation when clipping is enabled #423

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Fix bound calculation when clipping is enabled #423

merged 4 commits into from
Nov 5, 2024

Conversation

wouterlucas
Copy link
Contributor

@wouterlucas wouterlucas commented Oct 30, 2024 •
edited
Loading

Fixes #426

@wouterlucas wouterlucas mentioned this pull request Oct 30, 2024
Closed
@wouterlucas wouterlucas changed the title Always mark node out of bound if out of viewport Fix bound calculation when clipping is enabled Nov 4, 2024
@wouterlucas wouterlucas requested a review from jfboeve November 4, 2024 23:45
@wouterlucas wouterlucas added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit c1344e3 Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfboeve jfboeve jfboeve approved these changes

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boundary calculation when clipping is enabled ignores parent boundaries
2 participants
@wouterlucas @jfboeve