Fix ZWSP word break & seperate Font caches #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split cache between SDF and Canvas fonts to avoid collision when using the `textRendererOverride` property. Albeit this property is mainly used for testing, it generally feels safer to split Canvas & SDF font caches to avoid name clashes in the future.
jfboeve
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Zero-width space character in both the SDF and Canvas font engines. By adding the ZWSP character the font engines will word-break when there isn't enough space to render the text.
Additionally, during testing ran into a font cache collision when using
textRendererOverride- resolved this by splitting out the font cache in asdf_andcanvas_cache instead.