Fix Canvas2D fonts performance #253
Conversation
| forceFullLayoutCalc: false, | ||
| textW: 0, | ||
| textH: 0, | ||
| fontInfo: undefined, | ||
| fontFaceLoadedHandler: undefined, | ||
| isRenderable: false, | ||
| isScrollable: props.scrollable === true, |
There was a problem hiding this comment.
Is it necessary to make this a state property? If a user were to change the scrollable property of a Text Node mid-lifecycle it would not have any affect.
There was a problem hiding this comment.
that's exactly why. I figured it might be better to stay on the 3 canvasPage rendering instead of going back to the single, to avoid large discrepancies with rendering and positioning. If you feel that would be a better path, easy to flip it back to just state.props.scrollable and not have this here.
that said would this really be a usecase? a user repurposing a large chunk of scrollable text to a single non-scrollable piece of text?
wouterlucas
force-pushed
the
fix/canvas2d-fonts-performance
branch
from
f1a8101 to
66a5056
Compare
wouterlucas
force-pushed
the
fix/canvas2d-fonts-performance
branch
from
66a5056 to
a651bd5
Compare
| @@ -160,6 +160,18 @@ export class ImageTexture extends Texture { | |||
| return `ImageTexture,${key},${resolvedProps.premultiplyAlpha ?? 'true'}`; | |||
| } | |||
|
|
|||
| override free(): void { | |||
| if (this.props.src instanceof ImageData) { | |||
| // ImageData is a non-cacheable texture, so we need to free it manually | |||
There was a problem hiding this comment.
This is incorrect since the addition of the image factory/key PR #256
|
Replaced by #319 |
This PR adds a "single page" Canvas2D text rendering path for small Canvas text usage along side of the original "scrollable" Canvas2D text path.