Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector RTT support is broken #429

Closed
wouterlucas opened this issue Nov 4, 2024 · 0 comments · Fixed by #432
Closed

Inspector RTT support is broken #429

wouterlucas opened this issue Nov 4, 2024 · 0 comments · Fixed by #432

Comments

@wouterlucas
Copy link
Contributor

Inspector seems to break when RTT nodes are enabled, it even stalls the rendering itself.

Without inspector:
image (2)

With inspector enabled:
image (3)

With inspector enabled and RTT disabled:
image (4)
@wouterlucas wouterlucas changed the title Inspector RTT support Inspector RTT support is broken Nov 4, 2024
wouterlucas added a commit that referenced this issue Nov 4, 2024
@wouterlucas
fix: [Inspector] drop Proxies, set selective Object.defineProperties …
74b6b7b 
…traps

Proxies introduce a delay and differences in update graph behaviour which break the RTT parent/child updates on nodes itself, to avoid the issue only enable traps for inspector elements that we're actually interested in.

Fixes #429
This was referenced Nov 4, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024
@wouterlucas
fix: [Inspector] drop Proxies, set selective Object.defineProperties …
a0504ec 
…traps (#432)

Proxies introduce a delay and differences in update graph behaviour
which break the RTT parent/child updates on nodes itself, to avoid the
issue only enable traps for inspector elements that we're actually
interested in.

Fixes #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [Inspector] drop Proxies, set selective Object.defineProperties traps lightning-js/renderer
1 participant
@wouterlucas