Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDF Text: Infinite layout loop #220

Closed
frank-weindel opened this issue Mar 29, 2024 · 0 comments · Fixed by #224
Closed

SDF Text: Infinite layout loop #220

frank-weindel opened this issue Mar 29, 2024 · 0 comments · Fixed by #224
Assignees
@frank-weindel
Milestone
Release

Comments

@frank-weindel
Copy link
Collaborator

In v0.8.0, an infinite loop within the layoutText() method for SDF text can be triggered in certain cases when text wraps to a new line that can't fit within the height of a contain: both text node.

Offending commit: 2366aef
@frank-weindel frank-weindel self-assigned this Mar 29, 2024
This was referenced Mar 29, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 29, 2024
@frank-weindel
SDF: Fix infinite layout loop (#224)
1fcbd30 
Another hack to prevent an infinite loop situation that was introduced
in v0.8.0.

I've written up an issue to address more wholistically the issues with
the SDF layout engine
- #223

Fixes #220
@wouterlucas wouterlucas added this to the Release Candidate 1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frank-weindel frank-weindel

Labels
None yet
Projects
None yet
Milestone
Release
Development

Successfully merging a pull request may close this issue.

SDF: Fix infinite layout loop lightning-js/renderer
2 participants
@wouterlucas @frank-weindel