-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolved sans-serif font issue for firefox browser (#418)
The FireFox browser was throwing an error when using the default font for canvas. When the canvas text renderer tries to add the default font (fallback font). However during the creation of the WebFont (line: 120 CanvasTextRenderer) it creates a FontFace which creates a family property which is an empty string in FireFox. This is where we run into problems because that empty string is used as a key later on. I have resolved the issue by building in a fallback that in case the family returns an empty string it falls back to the fontFamily property of its super class.
- Loading branch information
Showing
3 changed files
with
7 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters