Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cra update #225

Merged
merged 199 commits into from
Mar 22, 2020
Merged
Show file tree
Hide file tree
Changes from 197 commits
Commits
Show all changes
199 commits
Select commit Hold shift + click to select a range
6a2a61a
Merge commit 'dc74990b89b5c6e143b522c759be3dac2c286514' into upstream
adammockor Oct 23, 2018
e40a6bc
Merge branch 'master' of github.com:facebook/create-react-app into up…
adammockor Nov 17, 2018
16211f4
Merge remote-tracking branch 'upstream/master' into upstream
adammockor Sep 8, 2019
a825e8f
Publish
iansu Sep 19, 2019
0dc69ec
Update runtime chunk name separator in docs (#7705)
samuelmeuli Sep 19, 2019
05f7924
Remove 'shortcut' link type before 'icon' (#7707)
lewislbr Sep 20, 2019
b1e6155
Guard polyfills against window possibly being undefined (#7205)
jxom Sep 24, 2019
6f5221c
Enable .eslintignore with extend flag (#7562)
igtm Sep 24, 2019
93150c5
Add "entrypoints" key to asset manifest (#7721)
samuelmeuli Sep 24, 2019
0d1775e
Update adding flow documentation (#7731)
FezVrasta Sep 25, 2019
42ee721
set output.globalObject to 'this' (#7742)
Sep 26, 2019
6533a6d
Update logic and log errors for EXTEND_ESLINT (#7530)
n1ru4l Sep 27, 2019
e624b75
update list of supported jest config overrides (#7601)
neilbryson Sep 27, 2019
4a3718b
Upgrade Webpack version (#7740)
RDIL Sep 30, 2019
c0d73ba
Close br tags in template README files (#7668)
rakannimer Sep 30, 2019
fefd716
Fix variable name casing in fileTransform (#7752)
lewislbr Sep 30, 2019
a10223d
Documentation typo fix (#7757)
tomer Sep 30, 2019
6f7b371
Fix linting error when using rest props (#7754)
alexandrtovmach Oct 1, 2019
71946b1
Add TSC_COMPILE_ON_ERROR setting (#6931)
kylebebak Oct 1, 2019
f36d61a
Remove switch case (#7729)
andrelmlins Oct 1, 2019
6980616
docs: note that v2 to v3 migration may require deletion of node_modul…
kimpers Oct 1, 2019
85aac9b
Stop hiding the column number of ESLint errors (#6980)
justingrant Oct 1, 2019
7e2b6b1
Support setting baseUrl to root directory (#7755)
robertvansteen Oct 2, 2019
6b8fa00
Use installing package manager in README (#7687)
ashr81 Oct 2, 2019
a8c379f
Merge remote-tracking branch 'upstream/master' into upstream
adammockor Oct 2, 2019
88cf8cd
Support production profiling with React Developer Tools (#7737)
JacobMGEvans Oct 3, 2019
6a74342
Prepare 3.2.0 release
iansu Oct 3, 2019
7fae307
Publish
iansu Oct 3, 2019
e51ea13
Temporarily disable Windows in CI (#7773)
ianschmitz Oct 3, 2019
ac93f31
Add babel runtime version to transform-runtime plugin to reduce… (#7726)
topaxi Oct 6, 2019
09cbb89
Add Babel sourcemap to resolve VSCode debugging issues (#7022)
justingrant Oct 10, 2019
9161ba8
Fix process type in TypeScript template (#7796)
fuszenecker Oct 10, 2019
f06ae8b
Account for browserslist environment variables (#7764)
Oct 11, 2019
c8ca307
Clarify dynamic import stage in docs (#7813)
aprilandjan Oct 13, 2019
dc4d62d
Update adding-typescript.md (#7815)
orta Oct 14, 2019
ab41c4c
Document how to use the .env file to enforce HTTPS (#7821)
TomasHubelbauer Oct 14, 2019
889df8e
Fix absolute paths issue in Jest (#7822)
robertvansteen Oct 14, 2019
4a4ae1e
Document correct default behavior for HOST var (#7823)
jsejcksn Oct 15, 2019
81c48dc
Fix grammar error in troubleshooting.md (#7824)
jakeboone02 Oct 15, 2019
9243305
Upgrade to docusaurus 2 (#7785)
endiliey Oct 15, 2019
b4068f2
Update doc publishing instructions
iansu Oct 15, 2019
584e352
Revert logo in templates (#7830)
iansu Oct 16, 2019
2da645c
feat: add additional Jest keys to whitelist (#7832)
mrmckeb Oct 16, 2019
ca37609
Link to React documentation for code splitting (#7686)
Hugodby Oct 16, 2019
053f977
Add a note about .eslingignore files being respected (#7809)
seanlaff Oct 16, 2019
4b024e9
added check for typescript template and unsupported node version (#7839)
awaseem Oct 17, 2019
ce968a9
Update getting-started.md (#7841)
reactjser Oct 18, 2019
07470fd
Link to ASP.NET Core docs (#7840)
Daniel15 Oct 19, 2019
da06c23
Update readme gif links (#7849)
cchanxzy Oct 20, 2019
9455ec5
Update adding-bootstrap.md (#7853)
Xuhao Oct 21, 2019
f337acc
Move unused eslint webpack import into @remove-on-eject block (#7856)
mrseanbaines Oct 21, 2019
9d00fce
📖 DOC: Improvement (#7819)
waahab Oct 21, 2019
7690af5
Upgrade terser & enable parallel minification in wsl (#7857)
endiliey Oct 21, 2019
9788522
Add a GitHub Action that runs the build script (#7861)
iansu Oct 22, 2019
42140e5
Edit InterpolateHtmlPlugin hook (#6448) (#6449)
GuiHash Oct 23, 2019
5ea3b34
Fix notations of loopback addresses (#7474)
wataash Oct 23, 2019
ea34c1d
Add Service-Worker header to checkValidServiceWorker (#6753)
darthmaim Oct 23, 2019
a351750
Add additional information for postcss errors (#6282) (#6352)
buildbreakdo Oct 23, 2019
4582491
Fix eslint complaints in build.js (#7870)
andriijas Oct 24, 2019
1d03579
Add Alex to lint documentation (#7852)
iansu Oct 24, 2019
a51729c
Bump docusaurus 🦖 (#7874)
andriijas Oct 24, 2019
c24314d
Dark scheme overlay (#7052)
Fabianopb Oct 24, 2019
7efe29b
Bump react (#7875)
andriijas Oct 24, 2019
f79f303
Bump styling related loaders (#7876)
andriijas Oct 24, 2019
e92db94
Remove alex precommit check (#7878)
iansu Oct 24, 2019
4c0c819
Add template support (#7716)
mrmckeb Oct 24, 2019
facd8f9
Prepare 3.3.0 beta
iansu Oct 24, 2019
3e7391d
If template name already starts with cra-template leave it alone (#7880)
iansu Oct 24, 2019
07ccad7
Update prerelease publishing instructions
iansu Oct 24, 2019
324428f
Upgrade packages and tweak config to adapt to new config format (#7814)
andriijas Oct 25, 2019
971f249
refactor: remove double coerce (#7882)
mrmckeb Oct 27, 2019
c34aa13
Add yarn.lock to .gitignore (#7789)
lukyth Oct 27, 2019
165765d
chore: Fix broken link for CRA deployment (#7897)
haruelrovix Oct 29, 2019
2c45a3c
chore: Fix broken link for e2e README (#7896)
haruelrovix Oct 29, 2019
2de57fe
Add @testing-library to the default templates (#7881)
kentcdodds Oct 29, 2019
b4fe788
Add numeric separator support (#7817)
tharun208 Oct 30, 2019
b68c777
Update open (#7910)
andriijas Oct 31, 2019
6d6dfa9
Mark TypeScript as an optional peer dependency (#7860)
dstaley Oct 31, 2019
9750738
Add restoreMocks to supported jest config keys (#7921)
ianschmitz Nov 3, 2019
d46da89
fix seperators typo (#7932)
donavon Nov 5, 2019
10daea2
No spinning React logo if `prefers-reduced-motion` (#7931)
donavon Nov 6, 2019
0c9fa8d
Made PRs welcome badge point to contributors guide (#7792)
jamesgeorge007 Nov 6, 2019
8a1ee2f
Make JavaScript and TypeScript templates consistent (#7944)
suprj Nov 7, 2019
211694a
Fix CI (#7951)
ianschmitz Nov 9, 2019
d12b4b6
Add optional chaining and nullish coalescing operators support (#7438)
renatoagds Nov 9, 2019
5cdc3cc
Add tests for optional chaining and null coalescing (#7952)
ianschmitz Nov 9, 2019
f01bfac
Upgrade jest-watch-typeahead (#7956)
Andarist Nov 10, 2019
30b491b
Fix light background in docusaurus night mode (#7936)
heyimalex Nov 13, 2019
915108b
Add placeholders where old template READMEs used to be (#7972)
iansu Nov 13, 2019
9df95df
Temporarily disable GitHub Actions (#7978)
iansu Nov 14, 2019
3d6d0a1
Prepare 3.3.0 beta
iansu Nov 14, 2019
58b4738
Bump dependencies (#7986)
ianschmitz Nov 16, 2019
e7cdde6
Support scoped templates (#7991)
klasbj Nov 18, 2019
3aaa3fa
Add contributors section to readme (#7995)
ianschmitz Nov 18, 2019
4b4f3f2
added e2e test for checking typescript template with unsupported node…
awaseem Nov 18, 2019
df5088d
Unpin dependencies in react-app-polyfill (#7999)
ianschmitz Nov 19, 2019
23d5776
Add scripts support to templates (#7989)
mrmckeb Nov 19, 2019
4604c5e
Override no-unused-expressions with the typescript-eslint version (#8…
maxdavidson Nov 20, 2019
5d24a5e
Prefix apple-touch-icon links with PUBLIC_URL. (#8005)
benblank Nov 24, 2019
82009f5
Bump webpack-dev-server (#7988)
ianschmitz Nov 24, 2019
1a66971
Bump dependencies (#8024)
ianschmitz Nov 24, 2019
99d71f3
Re-enable GitHub Actions (#8029)
iansu Nov 25, 2019
821fe6b
Update CHANGELOG
iansu Nov 27, 2019
6a3ccc3
Update CODEOWNERS
iansu Nov 27, 2019
fffc777
Remove no-unexpected-multiline rule (#8039)
iansu Nov 28, 2019
f6ba862
Add TypeScript peer dependency to react-scripts (#8038)
iansu Nov 28, 2019
29c5e55
Update template docs (#8050)
mrmckeb Nov 29, 2019
9654bef
Prepare 3.3.0 release
iansu Dec 4, 2019
0b45600
Update CHANGELOG
iansu Dec 4, 2019
9a817dd
Publish
iansu Dec 5, 2019
9f4cb4f
webpackHotDev now uses wss when https is used (#8079)
mikecaulley Dec 5, 2019
2ace7c2
Add custom-templates to docs sidebar (#8077)
ianschmitz Dec 5, 2019
8330e7c
Fix typo in CHANGELOG.md (#8080)
Trontor Dec 6, 2019
7317251
Merge remote-tracking branch 'upstream/master' into upstream
adammockor Dec 6, 2019
b19bffe
Remove error for @typescript-eslint/no-namespace (#7803)
szhu Dec 6, 2019
0b293e9
Fix CI build (#8122)
ianschmitz Dec 9, 2019
0327d89
Fix CSS font-face minification (#8106)
sidonaldson Dec 9, 2019
53a48c4
Add slashes to WebSocket protocol URL (#8116)
Baael Dec 9, 2019
b8ff97b
Fix typo in comment: `?.` is right, not `.?` (#8124)
vadzim Dec 9, 2019
1f1594d
chore: update docusaurus & tweak site (#8111)
endiliey Dec 10, 2019
8d1a4f2
[Security] Update terser webpack plugin (#8102)
RDIL Dec 11, 2019
ebcffda
Add current version and bin location to --info output (#8168)
heyimalex Dec 13, 2019
9922275
Bump pkgUp (#8163)
andriijas Dec 13, 2019
349a92a
Bump chalk (#8164)
andriijas Dec 13, 2019
ab2976f
Add link to Netlify in README
iansu Dec 13, 2019
f26de73
Bump internal dependencies (#8176)
andriijas Dec 14, 2019
f314855
Add package-runner note to readme (#8132)
JeromeDeLeon Dec 15, 2019
1a13b59
Update PWA docs links to point to template package (#8147)
peet Dec 15, 2019
30eaab4
Minor refactors in create-react-app (#8178)
heyimalex Dec 16, 2019
18e56da
fix: proactively append to .gitignore during init (#8028)
bmuenzenmeyer Dec 18, 2019
88a5435
Bump babel-plugin-tester and fix breaking changes (#8171)
andriijas Dec 19, 2019
3f2037b
Little typo (#8212)
sonyarianto Dec 20, 2019
c03bb36
Replace favicon in templates (#8194)
heyimalex Dec 30, 2019
fa85f03
Support shorthand scoped templates (#8298)
kevin940726 Jan 12, 2020
94932be
Allow additional package keys and add blacklist (#8082) (#8219)
tomvalorsa Jan 12, 2020
f875bb0
Minor grammatical edit (#8293)
egrim Jan 16, 2020
a608c5a
Update Dependencies (#8324)
RDIL Jan 21, 2020
dada035
Remove React.FC from Typescript template (#8177)
Retsam Jan 22, 2020
4bf14fa
Downgrade open from 7.0.0 to 6.4.0 (#8364)
vince1995 Jan 23, 2020
b855da5
Remove outdated babel plugins (#8353)
ianschmitz Jan 30, 2020
ddcb7d5
Add titleProp to SVGR ReactComponent type definition (#8099)
rhnorskov Jan 30, 2020
720d90b
Sync dependencies babel config (#8120)
ianschmitz Jan 30, 2020
cafd602
Update custom template docs with instructions for testing custom temp…
kevinold Jan 30, 2020
ca9c61e
Update setting-up-your-editor.md (#8247)
eip1599 Jan 30, 2020
dd0df73
Remove outdated docs regarding vscode eslint extension and type… (#8307)
john-james-gh Jan 30, 2020
e530598
Fix sass importLoaders (#8281)
mariusc23 Jan 30, 2020
ed162a3
Add "Disallow:" to robots.txt (#8255)
tomoyaf Jan 30, 2020
6ee4e91
Add helpful message to the footer (#6548)
pyrogenic Jan 31, 2020
03018d7
Update docs according to lint-staged v10 (#8394)
lukyth Jan 31, 2020
4da41b4
docs: Add troubleshooting documentation on ENOSPC (#8380)
huchenme Jan 31, 2020
a7b8732
Prepare 3.3.1 release
iansu Jan 31, 2020
d7c6842
Publish
iansu Jan 31, 2020
fb9745e
Make the PWA link point to the right place (#8379)
cassidoo Jan 31, 2020
d9e05f9
Update commit message to use imperative mood (#8377)
crstead Jan 31, 2020
d2de54b
Wider Chromium support for openBrowser (#8367)
Jan 31, 2020
325e599
fix(test): force install npm in e2e-behaviour (#8402)
iamandrewluca Jan 31, 2020
0db04ec
setupTestFrameworkScriptFile is deprecated (#8390)
JimmyLv Jan 31, 2020
1959131
Fix robots.txt for TS (#8403)
Kamahl19 Jan 31, 2020
9233caf
Update public folder usage docs to clarify globals (#8299)
keevan Jan 31, 2020
84d8b14
Run git init before template dependencies are installed (#8282)
lukaszfiszer Jan 31, 2020
cc985d0
Support JetBrains Rider IDE as an editor (#7948)
djpowell Jan 31, 2020
822422c
Enable custom sockjs pathname for hot reloading server. (#7750)
heygrady Jan 31, 2020
0299c0e
Add option to provide custom ssl certificates during development (#5845)
alexbrazier Jan 31, 2020
3190e4f
Handle service worker error in Firefox (#8272)
rosinghal Jan 31, 2020
1cbc6f7
feat(react-scripts): allow PUBLIC_URL in develoment mode (#7259)
iamandrewluca Feb 2, 2020
687c4eb
Change arrow functions to function declarations (#8412)
lewislbr Feb 3, 2020
cd2469e
Fix navbar line break in header (#8437)
esvyridov Feb 6, 2020
767aa18
Fixes unchecked access to 'deploy' script on build (#8292)
renato-bohler Feb 8, 2020
eb8e7be
Downgrade chalk for ie 11 support (#8439)
ianschmitz Feb 8, 2020
d45823c
fix(react-scripts): do not redirect served path if request may proxy …
iamandrewluca Feb 8, 2020
865ea05
fix(typescriptFormatter): use chalk@2 constructor (#8450)
iamandrewluca Feb 10, 2020
589b41a
update open to v7.0.2 (#8459)
vince1995 Feb 11, 2020
4784997
Correct webpack name casing (#8475)
lewislbr Feb 13, 2020
e579de1
Downgrade style-loader to v0.23.1 due to CSS modules hot reload… (#8378)
chybisov Feb 14, 2020
5ccee88
Prepare 3.4.0 release
iansu Feb 14, 2020
8b0dd54
Publish
iansu Feb 14, 2020
de6bc2f
Merge branch 'upstream' of https://github.com/lightingbeetle/lighter …
adammockor Feb 19, 2020
8f5d5e3
Merge branch 'upstream' into feat/cra-update
adammockor Feb 19, 2020
5efddd8
fix missing packages in react-scripts
adammockor Feb 19, 2020
af926d5
Bump pnp-webpack-plugin (#8509)
arcanis Feb 19, 2020
7e6d6cd
Closes webpack dev server and exits process on "end" stdin (#7203)
Feb 19, 2020
038e6fa
Widen eslint-config-react-app peer dependency versions (#7790)
lukyth Feb 19, 2020
2030ee1
Fix optional chaining and nullish coalescing support (#8526)
ianschmitz Feb 20, 2020
7d3b72c
Update template example in docs (#8561)
Vinnl Feb 29, 2020
8ba0ccb
Whitelist main in template.json (#8539)
EvanBoyle Feb 29, 2020
4d26208
Use native ESLint behaviour when extending (#8276)
mrmckeb Mar 1, 2020
3f699fd
Fix proxying API request docs (#8515)
hjr3 Mar 4, 2020
a452ddc
Bump dependencies (#8620)
ianschmitz Mar 9, 2020
6adb82a
Add React.StrictMode to default templates (#8558)
connkat Mar 10, 2020
d5b527f
Update to Babel 7.9 (#8681)
ianschmitz Mar 20, 2020
7641a3c
Prepare 3.4.1 release
iansu Mar 20, 2020
d2f813f
Publish
iansu Mar 21, 2020
b7da364
Squashed commit of the following:
jurajk Mar 21, 2020
18accdd
Merge remote-tracking branch 'create-react-app/master' into feat/cra-…
jurajk Mar 22, 2020
ce2574d
update archaic @babel/preset-env
jurajk Mar 22, 2020
9a6b5cd
Merge remote-tracking branch 'origin/master' into feat/cra-update
jurajk Mar 22, 2020
2524214
add changeset
jurajk Mar 22, 2020
18e7d3d
update changeset
adammockor Mar 22, 2020
9b6d672
update styleguide package.json
adammockor Mar 22, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/pink-candles-film.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'babel-preset-react-app': minor
'cra-template-typescript': minor
'cra-template': minor
'create-react-app': minor
'react-dev-utils': minor
'react-error-overlay': minor
'@lighting-beetle/lighter-react-scripts': minor
---

Update CRA
8 changes: 4 additions & 4 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ jobs:
name: Behavior
testScript: tasks/e2e-behavior.sh
configurations:
LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
LinuxNode8: { vmImage: 'ubuntu-18.04', nodeVersion: 8.x }
LinuxNode10: { vmImage: 'ubuntu-18.04', nodeVersion: 10.x }
# WindowsNode8: { vmImage: 'vs2017-win2016', nodeVersion: 8.x }
# WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
MacNode8: { vmImage: 'macOS-10.15', nodeVersion: 8.x }
MacNode10: { vmImage: 'macOS-10.15', nodeVersion: 10.x }

# ******************************************************************************
# Old Node test suite
Expand Down
2 changes: 1 addition & 1 deletion docusaurus/docs/advanced-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ You can adjust various development and production settings by setting environmen
| NODE_PATH | ✅ Used | ✅ Used | Same as [`NODE_PATH` in Node.js](https://nodejs.org/api/modules.html#modules_loading_from_the_global_folders), but only relative folders are allowed. Can be handy for emulating a monorepo setup by setting `NODE_PATH=src`. |
| INLINE_RUNTIME_CHUNK | 🚫 Ignored | ✅ Used | By default, Create React App will embed the runtime script into `index.html` during the production build. When set to `false`, the script will not be embedded and will be imported as usual. This is normally required when dealing with CSP. |
| IMAGE_INLINE_SIZE_LIMIT | 🚫 Ignored | ✅ Used | By default, images smaller than 10,000 bytes are encoded as a data URI in base64 and inlined in the CSS or JS build artifact. Set this to control the size limit in bytes. Setting it to 0 will disable the inlining of images. |
| EXTEND_ESLINT | ✅ Used | ✅ Used | When set to `true`, ESLint configs that extend `eslint-config-react-app` will be used by `eslint-loader`. Any rules that are set to `"error"` will stop the application from building. |
| EXTEND_ESLINT | ✅ Used | ✅ Used | When set to `true`, user provided ESLint configs will be used by `eslint-loader`. Note that any rules set to `"error"` will stop the application from building. |
| TSC_COMPILE_ON_ERROR | ✅ Used | ✅ Used | When set to `true`, you can run and properly build TypeScript projects even if there are TypeScript type check errors. These errors are printed as warnings in the terminal and/or browser console. |
2 changes: 1 addition & 1 deletion docusaurus/docs/custom-templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ If you're interested in building a custom template, first take a look at how we'
A template must have the following structure:

```
my-app/
cra-template-[template-name]/
README.md (for npm)
template.json
package.json
Expand Down
1 change: 0 additions & 1 deletion docusaurus/docs/integrating-with-an-api-backend.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ It allows creating hypermedia and GraphQL APIs in minutes.
It is shipped with an official Progressive Web App generator as well as a dynamic administration interface, both built for Create React App.
Check out [this tutorial](https://api-platform.com/docs/distribution).


## C# (ASP.NET Core)

ASP.NET Core has a React project template that uses Create React App. Check out [their documentation](https://docs.microsoft.com/en-us/aspnet/core/client-side/spa/react).
6 changes: 3 additions & 3 deletions docusaurus/docs/proxying-api-requests-in-development.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ $ yarn add http-proxy-middleware
Next, create `src/setupProxy.js` and place the following contents in it:

```js
const proxy = require('http-proxy-middleware');
const { createProxyMiddleware } = require('http-proxy-middleware');

module.exports = function(app) {
// ...
Expand All @@ -95,12 +95,12 @@ module.exports = function(app) {
You can now register proxies as you wish! Here's an example using the above `http-proxy-middleware`:

```js
const proxy = require('http-proxy-middleware');
const { createProxyMiddleware } = require('http-proxy-middleware');

module.exports = function(app) {
app.use(
'/api',
proxy({
createProxyMiddleware({
target: 'http://localhost:5000',
changeOrigin: true,
})
Expand Down
1 change: 0 additions & 1 deletion docusaurus/docs/setting-up-your-editor.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Note that any rules set to `"error"` will stop the project from building.
There are a few things to remember:

1. We highly recommend extending the base config, as removing it could introduce hard-to-find issues.
1. `.eslintignore` files will be respected
1. When working with TypeScript, you'll need to provide an `overrides` object for rules that should _only_ target TypeScript files.

In the below example:
Expand Down
6 changes: 6 additions & 0 deletions packages/babel-preset-react-app/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ module.exports = function(api, opts, env) {
removeImport: true,
},
],
// Optional chaining and nullish coalescing are supported in @babel/preset-env,
// but not yet supported in webpack due to support missing from acorn.
// These can be removed once webpack has support.
// See https://github.com/facebook/create-react-app/issues/8445#issuecomment-588512250
require('@babel/plugin-proposal-optional-chaining').default,
require('@babel/plugin-proposal-nullish-coalescing-operator').default,
].filter(Boolean),
overrides: [
isFlowEnabled && {
Expand Down
18 changes: 10 additions & 8 deletions packages/babel-preset-react-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "babel-preset-react-app",
"version": "9.1.1",
"version": "9.1.2",
"description": "Babel preset used by Create React App",
"repository": {
"type": "git",
Expand All @@ -21,17 +21,19 @@
"test.js"
],
"dependencies": {
"@babel/core": "7.8.4",
"@babel/core": "7.9.0",
"@babel/plugin-proposal-class-properties": "7.8.3",
"@babel/plugin-proposal-decorators": "7.8.3",
"@babel/plugin-proposal-nullish-coalescing-operator": "7.8.3",
"@babel/plugin-proposal-numeric-separator": "7.8.3",
"@babel/plugin-transform-flow-strip-types": "7.8.3",
"@babel/plugin-proposal-optional-chaining": "7.9.0",
"@babel/plugin-transform-flow-strip-types": "7.9.0",
"@babel/plugin-transform-react-display-name": "7.8.3",
"@babel/plugin-transform-runtime": "7.8.3",
"@babel/preset-env": "7.8.4",
"@babel/preset-react": "7.8.3",
"@babel/preset-typescript": "7.8.3",
"@babel/runtime": "7.8.4",
"@babel/plugin-transform-runtime": "7.9.0",
"@babel/preset-env": "7.9.0",
"@babel/preset-react": "7.9.1",
"@babel/preset-typescript": "7.9.0",
"@babel/runtime": "7.9.0",
"babel-plugin-macros": "2.8.0",
"babel-plugin-transform-react-remove-prop-types": "0.4.24"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template-typescript/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cra-template-typescript",
"version": "1.0.2",
"version": "1.0.3",
"keywords": [
"react",
"create-react-app",
Expand Down
7 changes: 6 additions & 1 deletion packages/cra-template-typescript/template/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ import './index.css';
import App from './App';
import * as serviceWorker from './serviceWorker';

ReactDOM.render(<App />, document.getElementById('root'));
ReactDOM.render(
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById('root')
);

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cra-template",
"version": "1.0.2",
"version": "1.0.3",
"keywords": [
"react",
"create-react-app",
Expand Down
7 changes: 6 additions & 1 deletion packages/cra-template/template/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ import './index.css';
import App from './App';
import * as serviceWorker from './serviceWorker';

ReactDOM.render(<App />, document.getElementById('root'));
ReactDOM.render(
<React.StrictMode>
<App />
</React.StrictMode>,
document.getElementById('root')
);

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
Expand Down
2 changes: 1 addition & 1 deletion packages/cra-template/template/src/serviceWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function registerValidSW(swUrl, config) {
function checkValidServiceWorker(swUrl, config) {
// Check if the service worker can be found. If it can't reload the page.
fetch(swUrl, {
headers: { 'Service-Worker': 'script' }
headers: { 'Service-Worker': 'script' },
})
.then(response => {
// Ensure service worker exists, and that we really are getting a JS file.
Expand Down
2 changes: 1 addition & 1 deletion packages/create-react-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-react-app",
"version": "3.4.0",
"version": "3.4.1",
"keywords": [
"react",
"lighter"
Expand Down
Loading