Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add failure threshold to deployments #72

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: add failure threshold to deployments #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3d9187
chore: add failure threshold to deployments
almeidabbm Jul 30, 2024
a93fb97
:robot: update docs [skip ci]
almeidabbm Jul 30, 2024
e22ff47
chore: bump version
almeidabbm Jul 30, 2024
e35d544
:robot: update docs [skip ci]
almeidabbm Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/lightdash/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.5.0
version: 1.5.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
18 changes: 11 additions & 7 deletions charts/lightdash/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

A Helm chart to deploy lightdash on kubernetes

![Version: 1.5.0](https://img.shields.io/badge/Version-1.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1121.0](https://img.shields.io/badge/AppVersion-0.1121.0-informational?style=flat-square)
![Version: 1.5.1](https://img.shields.io/badge/Version-1.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.1121.0](https://img.shields.io/badge/AppVersion-0.1121.0-informational?style=flat-square)

## Prerequisites

Expand Down Expand Up @@ -91,12 +91,14 @@ If you don't want helm to manage this, you may wish to separately create a secre
| ingress.hosts[0].paths[0].pathType | string | `"ImplementationSpecific"` | |
| ingress.tls | list | `[]` | |
| initContainers | list | `[]` | |
| lightdashBackend.livenessProbe.failureThreshold | int | `10` | |
| lightdashBackend.livenessProbe.initialDelaySeconds | int | `10` | |
| lightdashBackend.livenessProbe.periodSeconds | int | `10` | |
| lightdashBackend.livenessProbe.timeoutSeconds | int | `5` | |
| lightdashBackend.readinessProbe.initialDelaySeconds | int | `35` | |
| lightdashBackend.readinessProbe.periodSeconds | int | `35` | |
| lightdashBackend.readinessProbe.timeoutSeconds | int | `30` | |
| lightdashBackend.readinessProbe.failureThreshold | int | `30` | |
| lightdashBackend.readinessProbe.initialDelaySeconds | int | `10` | |
| lightdashBackend.readinessProbe.periodSeconds | int | `10` | |
| lightdashBackend.readinessProbe.timeoutSeconds | int | `5` | |
| lightdashBackend.terminationGracePeriodSeconds | int | `90` | |
| nameOverride | string | `""` | |
| nodeSelector | object | `{}` | |
Expand All @@ -113,13 +115,15 @@ If you don't want helm to manage this, you may wish to separately create a secre
| replicaCount | int | `1` | Specify the number of lightdash instances. |
| resources | object | `{}` | |
| scheduler.enabled | bool | `false` | |
| scheduler.livenessProbe.failureThreshold | int | `10` | |
| scheduler.livenessProbe.initialDelaySeconds | int | `10` | |
| scheduler.livenessProbe.periodSeconds | int | `10` | |
| scheduler.livenessProbe.timeoutSeconds | int | `5` | |
| scheduler.port | int | `8080` | |
| scheduler.readinessProbe.initialDelaySeconds | int | `35` | |
| scheduler.readinessProbe.periodSeconds | int | `35` | |
| scheduler.readinessProbe.timeoutSeconds | int | `30` | |
| scheduler.readinessProbe.failureThreshold | int | `30` | |
| scheduler.readinessProbe.initialDelaySeconds | int | `10` | |
| scheduler.readinessProbe.periodSeconds | int | `10` | |
| scheduler.readinessProbe.timeoutSeconds | int | `5` | |
| scheduler.replicas | int | `1` | |
| scheduler.resources.requests.cpu | string | `"475m"` | |
| scheduler.resources.requests.ephemeral-storage | string | `"1Gi"` | |
Expand Down
2 changes: 2 additions & 0 deletions charts/lightdash/templates/backendDeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,15 @@ spec:
initialDelaySeconds: {{ .Values.lightdashBackend.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.lightdashBackend.livenessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.lightdashBackend.livenessProbe.periodSeconds }}
failureThreshold: {{ .Values.lightdashBackend.livenessProbe.failureThreshold }}
httpGet:
path: /api/v1/livez
port: {{ .Values.service.port }}
readinessProbe:
initialDelaySeconds: {{ .Values.lightdashBackend.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.lightdashBackend.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.lightdashBackend.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.lightdashBackend.readinessProbe.failureThreshold }}
httpGet:
path: /api/v1/health
port: {{ .Values.service.port }}
Expand Down
2 changes: 2 additions & 0 deletions charts/lightdash/templates/workerDeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,15 @@ spec:
initialDelaySeconds: {{ .Values.scheduler.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.scheduler.livenessProbe.timeoutSeconds }}
periodSeconds: {{ .Values.scheduler.livenessProbe.periodSeconds }}
failureThreshold: {{ .Values.scheduler.livenessProbe.failureThreshold }}
httpGet:
path: /api/v1/health
port: {{ .Values.scheduler.port }}
readinessProbe:
initialDelaySeconds: {{ .Values.scheduler.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.scheduler.readinessProbe.periodSeconds }}
timeoutSeconds: {{ .Values.scheduler.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.scheduler.readinessProbe.failureThreshold }}
httpGet:
path: /api/v1/health
port: {{ .Values.scheduler.port }}
Expand Down
16 changes: 10 additions & 6 deletions charts/lightdash/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,14 @@ lightdashBackend:
initialDelaySeconds: 10
timeoutSeconds: 5
periodSeconds: 10
failureThreshold: 10
readinessProbe:
## If the value of periodSeconds is greater than initialDelaySeconds then the initialDelaySeconds would be ignored
## https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes
initialDelaySeconds: 35
timeoutSeconds: 30
periodSeconds: 35
initialDelaySeconds: 10
timeoutSeconds: 5
periodSeconds: 10
failureThreshold: 30

## Scheduler deployment specific configuration
scheduler:
Expand All @@ -240,8 +242,10 @@ scheduler:
initialDelaySeconds: 10
timeoutSeconds: 5
periodSeconds: 10
failureThreshold: 10
readinessProbe:
initialDelaySeconds: 35
timeoutSeconds: 30
periodSeconds: 35
initialDelaySeconds: 10
timeoutSeconds: 5
periodSeconds: 10
failureThreshold: 30