Filter models on tags before checking empties #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2024
PaddyAlton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conversation on Add support for ephemeral models.
This separates out the changes that were made in the
parser.parse_modelsfunction to the order in which tag-based filtering is done. The effect of these changes is to avoid checking models that aren't included by the tag selector (so e.g. placeholder model files that are empty but are not targeted by the tag selector won't cause the entire run to fail).N.B. this branch is stacked on top of the previous branch, so it contains both sets of changes. It is reliant on the previous changes to make sense.