Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jdk workaround #321

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Remove jdk workaround #321

merged 1 commit into from
Mar 16, 2022

Conversation

wsargent
Copy link
Contributor

@wsargent wsargent commented Aug 15, 2021 •
edited
Loading

Fix for #320

@mkurz
Copy link
Contributor

mkurz commented Mar 16, 2022

@raboof Can you trigger the build for this pull request again? Travis is using a Java version greater than 8u302 now:

[info] welcome to sbt 1.6.2 (Temurin Java 1.8.0_322)

Like described in #320 that was the requirement for this pull request to get merged.

@raboof
Copy link
Contributor

raboof commented Mar 16, 2022

Hmm, the new failure (no matching JDK found: 8) doesn't seem to have anything to do with the changes in this PR?

@mkurz
Copy link
Contributor

mkurz commented Mar 16, 2022 •
edited
Loading

Strange. Maybe clean the cache for this pull request? https://app.travis-ci.com/github/lightbend/ssl-config/caches (I don't have access and can't see that page)

mkurz
mkurz approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raboof Cleaning the cache did the trick. Please merge 👍

@raboof raboof merged commit b944c5d into lightbend:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurz mkurz mkurz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsargent @mkurz @raboof