Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some unfinished useful tools (path finding, class grouping in class mode, dot generation) #51

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jrudolph
Copy link

@jrudolph jrudolph commented Feb 1, 2018

I tried it on akka-http-core and, wow, there's some entanglement going on...

I needed a few extra tools to try to see what's going on:

  • in class mode, treat objects and traits as classes as well so that companions are grouped together
  • simple helpers to find some sample paths Cycles.pp, useful for finding concrete cycles between two classes
  • dot generation (doesn't seem particularly useful on reasonably sized code bases, takes dot ages to generate a graph and the result is hardly usable)

For now, I'm just putting them out here without any cleanup as I don't know when I'll be able to come back to it.

@jrudolph jrudolph changed the title [wip] Some unfinished useful tools [wip] Some unfinished useful tools (path finding, class grouping in class mode, dot generation) Feb 1, 2018
Copy link

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvican
Copy link

jvican commented Feb 3, 2018

CI seems to fail, though. Errors look legit.

@SethTisue
Copy link
Contributor

in class mode, treat objects and traits as classes as well so that companions are grouped together

@jrudolph fwiw, if you (or anyone else watching this repo) PRed that by itself, that sounds like a good change that would be easy to merge

@SethTisue
Copy link
Contributor

the dot generation part would probably be more useful if we had source-file-level and package-level aggregation

@SethTisue SethTisue added the WIP label May 2, 2018
@SethTisue SethTisue marked this pull request as draft October 19, 2020 21:21
@SethTisue SethTisue changed the title [wip] Some unfinished useful tools (path finding, class grouping in class mode, dot generation) Some unfinished useful tools (path finding, class grouping in class mode, dot generation) Oct 19, 2020
@SethTisue SethTisue removed the WIP label Oct 19, 2020
Base automatically changed from master to main March 19, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants