Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mimaReportBinaryIssues fail #289

Merged
merged 3 commits into from
Jan 16, 2019

Conversation

dwijnand
Copy link
Collaborator

@dwijnand dwijnand commented Jan 15, 2019

One can resolve this issue by:

  • setting mimaPreviousArtifacts,
  • setting mimaFailOnNoPrevious := false, or
  • setting mimaFailOnNoPrevious in ThisBuild := false

Also by disabling MimaPlugin, but maybe that's a bit heavy-handed.

Also, cleanup and dedup some.

Fixes #263

One can resolve this issue by:

    * setting mimaPreviousArtifacts,
    * setting `mimaFailOnNoPrevious := false`, or
    * setting `mimaFailOnNoPrevious in ThisBuild := false`

Also by disabling MimaPlugin, but maybe that's a bit heavy-handed.
@dwijnand dwijnand requested a review from 2m January 15, 2019 18:23
Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@2m 2m merged commit ec5d717 into lightbend-labs:master Jan 16, 2019
@dwijnand dwijnand deleted the make-mimaReportBinaryIssues-fail branch January 16, 2019 06:06
@dwijnand dwijnand added this to the 0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fail the check if plugin is enabled but no artifacts are set
2 participants