Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize cross scala version suffix. and/or fix README example #327

Closed
xuwei-k opened this issue Jul 10, 2019 · 1 comment · Fixed by #329
Closed

Don't normalize cross scala version suffix. and/or fix README example #327

xuwei-k opened this issue Jul 10, 2019 · 1 comment · Fixed by #329
Assignees
Milestone

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Jul 10, 2019

since 0.4.0

40a2cbe

build.sbt

scalaVersion := "2.12.8"

// works
mimaPreviousArtifacts := Set(
  "org.scalaz" %% "scalaz-core" % "7.2.28"
)

// does not work. unresolved dependency
mimaPreviousArtifacts := Set(
  "org.scalaz" % s"scalaz-core_${scalaBinaryVersion.value}" % "7.2.28"
)

log

[warn] 	module not found: org.scalaz#scalaz-core_2-12;7.2.28
[warn] ==== local: tried
[warn]   /Users/kenji/.ivy2/local/org.scalaz/scalaz-core_2-12/7.2.28/ivys/ivy.xml
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/org/scalaz/scalaz-core_2-12/7.2.28/scalaz-core_2-12-7.2.28.pom
[warn] ==== local-preloaded-ivy: tried
[warn]   /Users/kenji/.sbt/preloaded/org.scalaz/scalaz-core_2-12/7.2.28/ivys/ivy.xml
[warn] ==== local-preloaded: tried
[warn]   file:////Users/kenji/.sbt/preloaded/org/scalaz/scalaz-core_2-12/7.2.28/scalaz-core_2-12-7.2.28.pom
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: org.scalaz#scalaz-core_2-12;7.2.28: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

README says 😕

mimaPreviousArtifacts := Set("com.jsuereth" % "scala-arm_2.9.1" % "1.2")
xuwei-k added a commit to json4s/json4s that referenced this issue Jul 10, 2019
xuwei-k added a commit to json4s/json4s that referenced this issue Jul 10, 2019
xuwei-k added a commit to json4s/json4s that referenced this issue Jul 10, 2019
@dwijnand
Copy link
Collaborator

dwijnand commented Jul 10, 2019

Hey, @xuwei-k.

So I definitely think the README file should suggest %%.

I also think we should try to support both your % s"scalaz-core_${scalaBinaryVersion.value}" and ticket #168's %% "harmony_cats0.9.0_scalaz7.2".

I'm thinking: only normalising if the ModuleId is %%?

Need to think about it, but I'll try to release a bug-fix for this ASAP.

@dwijnand dwijnand self-assigned this Jul 10, 2019
@dwijnand dwijnand added this to the 0.5.0 milestone Jul 12, 2019
btomala pushed a commit to btomala/json4s that referenced this issue Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants