-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #587 from dwijnand/scala3
Add Scala 3 to MiMa's version matrix
- Loading branch information
Showing
43 changed files
with
214 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
...l-tests/src/test/abstract-class-extending-new-trait-with-abstract-method-ok/app/App.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
object App { | ||
def main(args: Array[String]): Unit = { | ||
println(new A { def foo = () }.foo) | ||
object a extends A { def foo() = () } | ||
println(a.foo()) | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
...onal-tests/src/test/abstract-class-extending-new-trait-with-abstract-method-ok/v2/A.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
abstract class A extends B { | ||
def foo: Unit | ||
def foo(): Unit | ||
} | ||
|
||
trait B { | ||
|
3 changes: 2 additions & 1 deletion
3
functional-tests/src/test/case-class-becomes-final-nok/app/App.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
object App { | ||
def main(args: Array[String]): Unit = { | ||
println(new A { def baz = 2 }.baz) | ||
object a extends A { def baz = 2 } | ||
println(a.baz) | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
functional-tests/src/test/case-class-concrete-becomes-abstract-nok/problems-3.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class A was concrete; is declared abstract in new version | ||
method apply()A in object A does not have a correspondent in new version | ||
static method apply()A in class A does not have a correspondent in new version | ||
the type hierarchy of object A is different in new version. Missing types {scala.deriving.Mirror$Product} | ||
method fromProduct(scala.Product)A in object A does not have a correspondent in new version | ||
static method fromProduct(scala.Product)A in class A does not have a correspondent in new version | ||
# the last 2 are not present in Scala 2 |
1 change: 1 addition & 0 deletions
1
functional-tests/src/test/case-class-constructor-becomes-private-ok/app/App.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
object App { | ||
def main(args: Array[String]): Unit = { | ||
println(new A) | ||
println(A()) | ||
} | ||
} |
4 changes: 4 additions & 0 deletions
4
functional-tests/src/test/case-class-constructor-becomes-private-ok/problems-3.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# In Scala 2 none of these changes are present. Positive progress IMO. | ||
method apply()A in object A does not have a correspondent in new version | ||
static method apply()A in class A does not have a correspondent in new version | ||
method copy()A in class A does not have a correspondent in new version |
3 changes: 2 additions & 1 deletion
3
functional-tests/src/test/class-becomes-final-nok/app/App.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
object App { | ||
def main(args: Array[String]): Unit = { | ||
println(new A { def baz = 2 }.baz) | ||
object a extends A { def baz = 2 } | ||
println(a.baz) | ||
} | ||
} |
2 changes: 1 addition & 1 deletion
2
functional-tests/src/test/class-constructor-generics-nok/app/App.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
object App { | ||
def main(args: Array[String]): Unit = { | ||
val result: String = new OptionPane(("foo", "bar")).show | ||
val result: String = new OptionPane(("foo", "bar")).show() | ||
println("result: " + result) | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
functional-tests/src/test/class-constructor-generics-nok/problems-3.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
method source()scala.Tuple2 in class OptionPane has a different generic signature in new version, where it is ()Lscala/Tuple2<LMyPane<TA;>;Ljava/lang/String;>; rather than ()Lscala/Tuple2<Ljava/lang/String;Ljava/lang/String;>;. See https://github.com/lightbend/mima#incompatiblesignatureproblem | ||
method show()java.lang.String in class OptionPane does not have a correspondent in new version | ||
method this(scala.Tuple2)Unit in class OptionPane has a different generic signature in new version, where it is <A:Ljava/lang/Object;>(Lscala/Tuple2<LMyPane<TA;>;Ljava/lang/String;>;)V rather than (Lscala/Tuple2<Ljava/lang/String;Ljava/lang/String;>;)V. See https://github.com/lightbend/mima#incompatiblesignatureproblem | ||
# In Scala 2 it's: | ||
# ... where it is (Lscala/Tuple2<LMyPane<TA;>;Ljava/lang/String;>;)V rather than ... | ||
# note there's no new type parameter | ||
# https://github.com/lampepfl/dotty/issues/10834 |
6 changes: 6 additions & 0 deletions
6
.../src/test/class-method-abstract-override-of-concrete-supertrait-method-nok/problems-3.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
in new version there is abstract method foo()Int in class B, which does not have a correspondent | ||
# what's missing is: | ||
# abstract method foo()Int in class B does not have a correspondent in new version | ||
# which is a `DirectAbstractMethodProblem`, rather than the above `ReversedAbstractMethodProblem` | ||
# not sure exactly what that means... ¯\_(ツ)_/¯ | ||
# https://github.com/lightbend/mima/issues/590 |
Oops, something went wrong.