-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll another release, to be sure sbt-ci-release is working #154
Comments
@SethTisue Now that I think about it can you hold off the patch release until #155 is done? I will try and do it tomorrow (shouldn't be too hard) but the reasoning is that currently its publishing cli related stuff along with |
sure, fine with me. see also #156 |
#158 adds release steps to the repo ( |
@mdedetrich I added the secrets (using my personal Sonatype account, which has permissions for com.lightbend publishing) |
after publishing, I'll need to revise retronym/homebrew-formulas#5 |
@mdedetrich I can't remember where I left off on this. Like was I waiting for something else to happen? If you can't think of anything that's still pending, I guess I should try to push a tag? (There was #153, but since it hasn't progressed, maybe we should release anyway and figure on releasing again if a fix comes in.) |
Yeah I was actually expecting a release at some point, the Windows fix can wait |
(release steps from RELEASING.md) Core JAR
CLI jar
|
@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here? I'm not used to a setup with everything in |
🎶 Please release me, let me go 🎶 |
Did you push a tag? Pushing a tag with the EDIT: So there is this screen Which I guess is referring to the commit and not when it was pushed? Either case im looking into it. |
So I just checked the logs and it did trigger https://github.com/lightbend-labs/jardiff/actions/runs/6962890536/job/18947517194 and publish, it should be available by now? |
Huh, I don't remember that being there when I looked, maybe Actions was backed up or something 🤷 (btw the job shows up with the name "Clean", is that easily fixable?) https://github.com/lightbend-labs/jardiff/releases/tag/v1.9.0 available: https://central.sonatype.com/artifact/com.lightbend/jardiff-core_2.13 |
@mdedetrich thanks for the help with this! |
There are 2 jobs, clean and continuous integration. The actual publish is done in continuous integration and it only triggers if you happen to push a tag, which you can find here https://github.com/lightbend-labs/jardiff/actions/runs/6962890536 See how both the publish job is triggered and in the top left you see "Continuous Integration" |
Got it 👍 |
@SethTisue Did you end up making a homebrew release of the new version? |
@mdedetrich I need Jason to merge retronym/homebrew-formulas#5 . I'll ping him. |
'tis merged |
now that #152 by @mdedetrich is merged, let's make sure we can use it
first, I'll need to add publishing secrets to the GitHub Actions config
The text was updated successfully, but these errors were encountered: