Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll another release, to be sure sbt-ci-release is working #154

Closed
SethTisue opened this issue Oct 31, 2023 · 19 comments
Closed

Roll another release, to be sure sbt-ci-release is working #154

SethTisue opened this issue Oct 31, 2023 · 19 comments
Assignees

Comments

@SethTisue
Copy link
Contributor

now that #152 by @mdedetrich is merged, let's make sure we can use it

first, I'll need to add publishing secrets to the GitHub Actions config

@mdedetrich
Copy link
Collaborator

mdedetrich commented Oct 31, 2023

@SethTisue Now that I think about it can you hold off the patch release until #155 is done? I will try and do it tomorrow (shouldn't be too hard) but the reasoning is that currently its publishing cli related stuff along with Main which doesn't make sense

@SethTisue
Copy link
Contributor Author

SethTisue commented Oct 31, 2023

sure, fine with me. see also #156

@SethTisue SethTisue assigned SethTisue and unassigned SethTisue Oct 31, 2023
@SethTisue SethTisue changed the title Roll a patch release, to be sure sbt-ci-release is working Roll another release, to be sure sbt-ci-release is working Nov 2, 2023
@SethTisue
Copy link
Contributor Author

#158 adds release steps to the repo (RELEASING.md)

@SethTisue
Copy link
Contributor Author

@mdedetrich I added the secrets (using my personal Sonatype account, which has permissions for com.lightbend publishing)

@SethTisue
Copy link
Contributor Author

after publishing, I'll need to revise retronym/homebrew-formulas#5

@SethTisue
Copy link
Contributor Author

@mdedetrich I can't remember where I left off on this. Like was I waiting for something else to happen? If you can't think of anything that's still pending, I guess I should try to push a tag? (There was #153, but since it hasn't progressed, maybe we should release anyway and figure on releasing again if a fix comes in.)

@mdedetrich
Copy link
Collaborator

Yeah I was actually expecting a release at some point, the Windows fix can wait

@SethTisue
Copy link
Contributor Author

SethTisue commented Nov 22, 2023

(release steps from RELEASING.md)

Core JAR

  • create and tag the release via the GitHub web UI
  • check the GitHub Actions log to see that publishing succeeded
  • wait for the artifact to appear on Maven Central

CLI jar

  • locally, on JDK 8, run sbt cli/assembly
  • rename the resulting JAR to just jardiff.jar
  • attach the JAR to the release in the GitHub web UI
  • PR the change to the homebrew formula, using shasum -a 256 jardiff.jar to compute the SHA

@SethTisue
Copy link
Contributor Author

SethTisue commented Nov 22, 2023

@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?

I'm not used to a setup with everything in ci.yml — all the repos I work on have separate ci.yml and release.yml. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself

@som-snytt
Copy link

🎶 Please release me, let me go 🎶

@mdedetrich
Copy link
Collaborator

mdedetrich commented Nov 23, 2023

@mdedetrich no publish job was triggered. there must have been a flaw in #152 ? is it obvious to you what went wrong here?

I'm not used to a setup with everything in ci.yml — all the repos I work on have separate ci.yml and release.yml. also I'm not familiar with sbt-github-actions, so I'm hoping you can look into this yourself

Did you push a tag? Pushing a tag with the vx.x.x pattern is what forces a publish and judging from https://github.com/lightbend-labs/jardiff/tags the last tag was pushed 2 weeks ago?

EDIT: So there is this screen

image

Which I guess is referring to the commit and not when it was pushed? Either case im looking into it.

@mdedetrich
Copy link
Collaborator

So I just checked the logs and it did trigger https://github.com/lightbend-labs/jardiff/actions/runs/6962890536/job/18947517194 and publish, it should be available by now?

@SethTisue
Copy link
Contributor Author

SethTisue commented Nov 23, 2023

Huh, I don't remember that being there when I looked, maybe Actions was backed up or something 🤷

(btw the job shows up with the name "Clean", is that easily fixable?)

https://github.com/lightbend-labs/jardiff/releases/tag/v1.9.0

available: https://central.sonatype.com/artifact/com.lightbend/jardiff-core_2.13

retronym/homebrew-formulas#5

@SethTisue
Copy link
Contributor Author

@mdedetrich thanks for the help with this!

@mdedetrich
Copy link
Collaborator

(btw the job shows up with the name "Clean", is that easily fixable?)

There are 2 jobs, clean and continuous integration.

image

The actual publish is done in continuous integration and it only triggers if you happen to push a tag, which you can find here https://github.com/lightbend-labs/jardiff/actions/runs/6962890536

image

See how both the publish job is triggered and in the top left you see "Continuous Integration"

@SethTisue
Copy link
Contributor Author

Got it 👍

@mdedetrich
Copy link
Collaborator

@SethTisue Did you end up making a homebrew release of the new version?

@SethTisue
Copy link
Contributor Author

@mdedetrich I need Jason to merge retronym/homebrew-formulas#5 . I'll ping him.

@SethTisue
Copy link
Contributor Author

'tis merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants