-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for VPP 21.06 #1808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusmilan
force-pushed
the
update-binapi-2106
branch
5 times, most recently
from
June 16, 2021 15:03
73a5a7e
to
b864b35
Compare
VladoLavor
reviewed
Jun 23, 2021
juliusmilan
force-pushed
the
update-binapi-2106
branch
2 times, most recently
from
June 24, 2021 06:59
cfad61f
to
7db3082
Compare
juliusmilan
changed the title
WIP update binapi 21.06 & abf plugin
This PR adds support for VPP 21.06
Jun 24, 2021
juliusmilan
changed the title
This PR adds support for VPP 21.06
feat: add support for VPP 21.06
Jun 24, 2021
juliusmilan
changed the title
feat: add support for VPP 21.06
feat: Add support for VPP 21.06
Jun 24, 2021
juliusmilan
force-pushed
the
update-binapi-2106
branch
from
June 24, 2021 08:39
7db3082
to
857f455
Compare
VladoLavor
reviewed
Jun 24, 2021
VladoLavor
reviewed
Jun 24, 2021
Run |
juliusmilan
force-pushed
the
update-binapi-2106
branch
from
June 24, 2021 11:42
857f455
to
6dbd31c
Compare
VladoLavor
previously approved these changes
Jun 24, 2021
juliusmilan
force-pushed
the
update-binapi-2106
branch
from
July 1, 2021 05:51
b375fca
to
c8708b3
Compare
Signed-off-by: Július Milan <[email protected]> Co-authored-by: mhalaj1 <[email protected]>
juliusmilan
force-pushed
the
update-binapi-2106
branch
from
July 1, 2021 06:45
c8708b3
to
af60b42
Compare
Signed-off-by: Vladimir Lavor <[email protected]>
Signed-off-by: Július Milan <[email protected]>
Signed-off-by: Július Milan <[email protected]>
ondrej-fabry
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for VPP 21.06
The only significant changes were done for natplugin and ipsecplugin.
In natplugin, there were internal changes caused by separation of VPP nat plugin to 2 separate plugins, for ED and EI nat. However for vpp-agent user perspective, the logic and functionality remained the same, just the code was accommodated, to cover two VPP plugins under one roof. In future, when VPP (EI and ED) nat plugins became differ more and more, there might be a need to separate even vpp-agent natplugin to map 1:1 to VPP nat plugins.
In ipsecplugin, IPSecLink message logic changed, now this message serves just for creation of ipsec interface and bunch of fields, for assigning cryptographic information was deprecated for VPP 21.06. Assigning of cryptographic information to the link is now done by separate messages. Unit tests were updated.