Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agentctl): Add config.resync subcommand (with resync) #1642

Merged
merged 7 commits into from
Mar 18, 2020

Conversation

ondrej-fabry
Copy link
Member

No description provided.

- TxnType and ResyncType are now marshalled as strings (unmarshalling works for both)
- Added tests for json encoding/decoding of TxnType and ResyncType

Signed-off-by: Ondrej Fabry <[email protected]>
Signed-off-by: Ondrej Fabry <[email protected]>
@ondrej-fabry ondrej-fabry self-assigned this Mar 17, 2020
@ondrej-fabry ondrej-fabry changed the title Agentctl config subcommand feat: Agentctl config subcommand Mar 17, 2020
@ondrej-fabry ondrej-fabry changed the title feat: Agentctl config subcommand feat: Agentctl config.resync subcommand (with resync) Mar 17, 2020
@ondrej-fabry ondrej-fabry changed the title feat: Agentctl config.resync subcommand (with resync) feat(agentctl): Add config.resync subcommand (with resync) Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1642 into master will increase coverage by 0.42%.
The diff coverage is 43.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
+ Coverage   57.71%   58.13%   +0.42%     
==========================================
  Files         495      293     -202     
  Lines       40486    23836   -16650     
==========================================
- Hits        23367    13858    -9509     
+ Misses      14662     8847    -5815     
+ Partials     2457     1131    -1326     
Flag Coverage Δ
#e2e ?
#unittests 58.13% <43.66%> (-0.72%) ⬇️

@ondrej-fabry ondrej-fabry merged commit 83d2423 into ligato:master Mar 18, 2020
@ondrej-fabry ondrej-fabry deleted the agentctl branch March 18, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants