Fix IPv6 detection #1355
Merged
Fix IPv6 detection #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <[email protected]>
VladoLavor
approved these changes
May 27, 2019
ondrej-fabry
added a commit
to ondrej-fabry/vpp-agent
that referenced
this pull request
May 27, 2019
Signed-off-by: Ondrej Fabry <[email protected]>
VladoLavor
pushed a commit
to VladoLavor/vpp-agent
that referenced
this pull request
Jun 5, 2019
Signed-off-by: Ondrej Fabry <[email protected]>
VladoLavor
pushed a commit
to VladoLavor/vpp-agent
that referenced
this pull request
Jun 5, 2019
Signed-off-by: Ondrej Fabry <[email protected]>
VladoLavor
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Update NAT example for VPP 19.04. Signed-off-by: Milan Lenco <[email protected]> * Remove unused dep from Gopkg.toml Signed-off-by: Ondrej Fabry <[email protected]> * Install vpp-plugin-dpdk package Signed-off-by: Ondrej Fabry <[email protected]> * Install python3-cffi package (dependency for python3-vpp-api) Signed-off-by: Ondrej Fabry <[email protected]> * Rework RxPlacement and RxMode to allow per-queue configuration Signed-off-by: Milan Lenco <[email protected]> * Fix build. Signed-off-by: Milan Lenco <[email protected]> * remove tapv1 test and fix tests (#1339) Signed-off-by: AndrejKilvady <[email protected]> * Use arrays instead of maps for RxMode and placement. Signed-off-by: Milan Lenco <[email protected]> * Fix for SRv6 localsid delete in nonzero vrf tables (#1338) Signed-off-by: Filip Gschwandtner <[email protected]> * fix robot test (#1340) Signed-off-by: AndrejKilvady <[email protected]> * Add etcd ansible python plugin (#1336) * Add etcd ansible python plugin * Add example ansible playbook * Fix indentation * Update example playbook Signed-off-by: miroslav.kovac <[email protected]> * Fix stats publishers (#1341) * Fix *-ifplugin config names * Unset default stats publishers used as fallback without config Signed-off-by: Ondrej Fabry <[email protected]> * Define datasyncs used for setting publishers from config or env Signed-off-by: Ondrej Fabry <[email protected]> * Add dependency on link-state for rx placement and rx mode. Signed-off-by: Milan Lenco <[email protected]> * Update and add UTs for rx placement and rx mode Signed-off-by: Milan Lenco <[email protected]> * Adapter for rx mode descriptor Signed-off-by: Milan Lenco <[email protected]> * Update GoVPP (#1342) Signed-off-by: Ondrej Fabry <[email protected]> * Bug fixing txn post-processing in kvscheduler. Signed-off-by: Milan Lenco <[email protected]> * Add example for rx-placement and rx-mode. Signed-off-by: Milan Lenco <[email protected]> * Pluralize rx-mode and rx-placement Signed-off-by: Milan Lenco <[email protected]> * Add check for multiple descriptors matching the same key. Signed-off-by: Milan Lenco <[email protected]> * Pluralize also key for all rx-modes of an interface Signed-off-by: Milan Lenco <[email protected]> * Remove unnecessary LinkIsUp from interface metadata Signed-off-by: Milan Lenco <[email protected]> * Refactor image building to use ligato/vpp-base (#1343) * Refactor image builds to use ligato/vpp-base Signed-off-by: Ondrej Fabry <[email protected]> * Fixed automatic launching of SRv6 crud robot tests (#1346) Signed-off-by: Filip Gschwandtner <[email protected]> * remove agent-ctl and kafka (#1345) Signed-off-by: AndrejKilvady <[email protected]> * Define env vars for overriding start/stop timeouts of agent Signed-off-by: Ondrej Fabry <[email protected]> * Support building images with different VPP versions (#1348) Signed-off-by: Ondrej Fabry <[email protected]> * Pass image_tag Signed-off-by: Ondrej Fabry <[email protected]> * Fix installing deb packages for VPP 19.01 Signed-off-by: Ondrej Fabry <[email protected]> * DHCP proxy for VPP (#1349) * Add DHCP proxy plugin initial commit Signed-off-by: miroslav.kovac <[email protected]> * Fix nil dump Signed-off-by: miroslav.kovac <[email protected]> * Update dhcp_proxy.go Signed-off-by: miroslav.kovac <[email protected]> * Update plugin fix namings add validate and dependecy implementation fix validation in write new dhcp proxy Signed-off-by: miroslav.kovac <[email protected]> * Change isIPv6 to 0 if IPv4 Signed-off-by: miroslav.kovac <[email protected]> * Update dump function Signed-off-by: miroslav.kovac <[email protected]> * Update Ip formatting Signed-off-by: miroslav.kovac <[email protected]> * Fix older version Signed-off-by: miroslav.kovac <[email protected]> * Add DHCPv6 support Signed-off-by: miroslav.kovac <[email protected]> * Fix bugs, clean up Signed-off-by: miroslav.kovac <[email protected]> * Clean up and update validate implementation Signed-off-by: miroslav.kovac <[email protected]> * Add messages to handler Signed-off-by: miroslav.kovac <[email protected]> * Update error message Signed-off-by: miroslav.kovac <[email protected]> * remove unused ipToAddress Signed-off-by: miroslav.kovac <[email protected]> * Update error message Signed-off-by: miroslav.kovac <[email protected]> * Update validate implementation Signed-off-by: miroslav.kovac <[email protected]> * Update error message Signed-off-by: miroslav.kovac <[email protected]> * Regenerate proto files Signed-off-by: Ondrej Fabry <[email protected]> * Fix travis errors Signed-off-by: miroslav.kovac <[email protected]> Co-authored-by: Ondrej Fabry <[email protected]> * Fix caching for building docker images Signed-off-by: Ondrej Fabry <[email protected]> * Make channel for notifications buffered (#1352) Even though notifications are processed quickly in separate go routines, it still may not be enough if multiple of them are received at roughly the same time, causing potential drops. Added small buffer for the notification channel. * Remove default for agent version and add grpc perf to dockerignore Signed-off-by: Ondrej Fabry <[email protected]> * Add interfaces metrics to telemetry plugin (#1351) * Add interface metrics to telemetry plugin * Change telemetry URL for prometheus export to `/metrics/vpp` * Cleanup metric names * Rename node count to counter Signed-off-by: Ondrej Fabry <[email protected]> * Fix IPv6 detection (#1355) Signed-off-by: Ondrej Fabry <[email protected]> * add ABF to config data model (#1356) Signed-off-by: Vladimir Lavor <[email protected]> * Improve error logs for invalid key value pairs (#1359) Signed-off-by: Ondrej Fabry <[email protected]> * Minor Code Fixes (#1361) * fix panic if model is registered without name * fix key variable shadowed * Allow disabling interface stats reading Signed-off-by: Ondrej Fabry <[email protected]> * replace supervisord with vpp-agent-init (#1318) * update cn-infra dep * add vpp-agent-init * fix deps * remove logfile paths from supervisor conf * update to latest supervisor Signed-off-by: Vladimir Lavor <[email protected]> * Allow skipping binapi check in dev docker image Signed-off-by: Ondrej Fabry <[email protected]> * fix crash for iptables rulechain with default microservice Signed-off-by: Vladimir Lavor <[email protected]> * Support for VPP 19.08-rc0 (#1357) * Add preliminary support for VPP 19.08 Signed-off-by: Ondrej Fabry <[email protected]> * updated govppmux to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * updated abf and acl plugins to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * updated ifplugin and ipsec plugin to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * update l2 and l3 plugin to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * updated nat and punt plugins to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * update sr and stn plugin to 1908 Signed-off-by: Vladimir Lavor <[email protected]> * regenerate binapi for ip, nat and session Signed-off-by: Vladimir Lavor <[email protected]> * improvements Signed-off-by: Vladimir Lavor <[email protected]> * telemetry 1908 Signed-off-by: Vladimir Lavor <[email protected]> * Update VPP images Signed-off-by: Ondrej Fabry <[email protected]> * Fix VPP version in vppcalls handlers Signed-off-by: Ondrej Fabry <[email protected]> * Add config status publishing for config items (#1364) Signed-off-by: Ondrej Fabry <[email protected]> * Add some (temporary) debug logs for interface state updates (#1367) Signed-off-by: Milan Lenco <[email protected]> * vpp updated to v19.08-rc0.324-g2ecf18a55 (#1366) * update govpp * update vpp to v19.08-rc0~324-g2ecf18a55 * update vppcalls * update punt tests Signed-off-by: Vladimir Lavor <[email protected]> * Update CHANGELOG for v2.1.1 Signed-off-by: Ondrej Fabry <[email protected]> * Update README.md * add rest support for ipsec and punt (#1368) * remove nul chars from retrieved punt socket path * add rest support for ipsec and punt Signed-off-by: Vladimir Lavor <[email protected]> * Fix init order of state channel (#1369) Signed-off-by: Ondrej Fabry <[email protected]> * initialize abf plugin handler in configurator (#1371) Signed-off-by: Vladimir Lavor <[email protected]> * Add env var (RESYNC_TIMEOUT) for setting resync timeout (#1372) Signed-off-by: Ondrej Fabry <[email protected]> * Minor enhancements in Linux interface descriptor (#1374) Signed-off-by: Ondrej Fabry <[email protected]> * tweaked interface statistics Signed-off-by: Vladimir Lavor <[email protected]> * wip Signed-off-by: Vladimir Lavor <[email protected]> * Revert "wip" This reverts commit e993d3b. * Revert "tweaked interface statistics" This reverts commit 8715c96. * Retrieve cmdline (config) after conencting to VPP (#1381) Signed-off-by: Ondrej Fabry <[email protected]> * fix punt dump for all vpp versions (#1379) * fix dump punt log * fix punt dump for all vpp versions Signed-off-by: Vladimir Lavor <[email protected]> * Fix dumps for unavailable handlers - do not return error for dumps when some handlers are not available - log all unavailable handlers during initialization of restapi/configurator - remove unused dump channels from vppcalls Signed-off-by: Ondrej Fabry <[email protected]> * Revert "fix punt dump for all vpp versions" (#1385) This reverts commit 36636ab. * Remove unused dump channel Signed-off-by: Ondrej Fabry <[email protected]> * vpp.punt: Add support for punt exceptions (#1384) * Add support for punt exceptions - added support for punt exceptions in puntplugin - fixed deleting of registered sockets after resync - forcing recreation of registered sockets using prefix '!' in socket path - SetPunt is not used anymore Signed-off-by: Ondrej Fabry <[email protected]> * Update documentation for VPP Punt API Signed-off-by: Ondrej Fabry <[email protected]> * Add punt exceptions to clientv2 Signed-off-by: Ondrej Fabry <[email protected]> * Add fixes for punt plugin (#1389) - do not check socket path for punt exceptions to prevent recreation - add depenency for RX interface to ip redirect punt - implement IP redirect dump (only for 19.08) - add workaround for publishing socket to punt exceptions as well - properly deregister punt exeption on delete - return pathname from registration when adding punt exception - add workaround with ! prefix to punt exceptions - publish socket paths to status with client TTL Signed-off-by: Ondrej Fabry <[email protected]> * Update VPP 19.08 (#1394) * update to vpp v19.08-rc0~432-gb63dbc537 (#1390) Signed-off-by: Vladimir Lavor <[email protected]> * Update GoVPP and vpp.env Signed-off-by: Ondrej Fabry <[email protected]> * Fix nil stats in telemetry Signed-off-by: Ondrej Fabry <[email protected]> * Regenerate binapi for VPP 19.04 Signed-off-by: Ondrej Fabry <[email protected]> * fix IPSec security associations tunnel mode (#1395) Signed-off-by: Vladimir Lavor <[email protected]> * fix building of docker images for ARM64 (make images) (#1376) * agentctl: Add import command for importing config from file Signed-off-by: Ondrej Fabry <[email protected]> * agentctl: Fix import of full keys Signed-off-by: Ondrej Fabry <[email protected]> * agentctl: Add flag to set number of ops per transaction Signed-off-by: Ondrej Fabry <[email protected]> * agentctl: Add gRPC support to import command Signed-off-by: Ondrej Fabry <[email protected]> * Move debugging into debug package (#1397) Signed-off-by: Ondrej Fabry <[email protected]> * govppmux stats REST handler (#1396) * Add govppmux stats handler for REST and improve stats Signed-off-by: Ondrej Fabry <[email protected]> * Allow disabling status publishing and interface stats collection Signed-off-by: Ondrej Fabry <[email protected]> * agentctl: Remove unused type Signed-off-by: Ondrej Fabry <[email protected]> * Update README.md (#1400) * Performance improvements around isNodeReady (#1402) * Add some (temporary) debug logs for interface state updates Signed-off-by: Milan Lenco <[email protected]> * Performance improvements around isNodeReady Signed-off-by: Milan Lenco <[email protected]> * Update GoVPP and use pure Go client adapters by default (#1401) * Update GoVPP and use pure Go client adapters by default Signed-off-by: Ondrej Fabry <[email protected]> * Update GoVPP with fix for duplicate objects Signed-off-by: Ondrej Fabry <[email protected]> * Add derived (property) key-value marking interface with at leas… (#1403) Signed-off-by: Milan Lenco <[email protected]> * Update perf tests (#1404) * Update perf test Signed-off-by: Ondrej Fabry <[email protected]> * Update perf test Signed-off-by: Ondrej Fabry <[email protected]> * Update perf test Signed-off-by: Ondrej Fabry <[email protected]> * Cleanup puntplugin (#1405) Signed-off-by: Ondrej Fabry <[email protected]> * vpp19.08 updated to rc0.581-g3eea9de89 (#1407) * update abf plugin * update interface plugin * update l2 plugin * update L3 plugin * removed redundant log * code improvements and cleanup * added support for VRF index map * l3 plugin dumps ipv4 and ipv6 routes * add vrf proto to metadata Signed-off-by: Vladimir Lavor <[email protected]> * VPP integration tests (#1409) * Add initial vpp integration test Signed-off-by: Ondrej Fabry <[email protected]> * Test integration tests on travis Signed-off-by: Ondrej Fabry <[email protected]> * Skip integration tests on travis Signed-off-by: Ondrej Fabry <[email protected]> * Update vpp integration tests Signed-off-by: Ondrej Fabry <[email protected]> * Set govpp logger level on debug Signed-off-by: Ondrej Fabry <[email protected]> * Add integration test for interface Signed-off-by: Ondrej Fabry <[email protected]> * Run integration tests and verify binapi for each VPP version in travis Signed-off-by: Ondrej Fabry <[email protected]> * Fix env matrix Signed-off-by: Ondrej Fabry <[email protected]> * Try fix env Signed-off-by: Ondrej Fabry <[email protected]> * Try travis fix Signed-off-by: Ondrej Fabry <[email protected]> * Add README for vpp integration tests Signed-off-by: Ondrej Fabry <[email protected]> * Clean stages Signed-off-by: Ondrej Fabry <[email protected]> * Fix stages Signed-off-by: Ondrej Fabry <[email protected]> * Add go_import_path back Signed-off-by: Ondrej Fabry <[email protected]> * Regenerate binapi for VPP 19.01 Signed-off-by: Ondrej Fabry <[email protected]> * Update Go in docker Signed-off-by: Ondrej Fabry <[email protected]> * Add abf patch to VPP 1901 binapi Signed-off-by: Ondrej Fabry <[email protected]> * Fix binapi patches for VPP 19.08 Signed-off-by: Ondrej Fabry <[email protected]> * Fix binapi patches for VPP 19.08 Signed-off-by: Ondrej Fabry <[email protected]> * Update GoVPP & aggregated watcher (#1410) * Update GoVPP Signed-off-by: Ondrej Fabry <[email protected]> * Add aggregated watcher from vpp1908 branch Signed-off-by: Ondrej Fabry <[email protected]> * Fix key collisions for vpp routes (#1411) * Add outgoing interface to route key Signed-off-by: Ondrej Fabry <[email protected]> * Add unit tests for vpp route key Signed-off-by: Ondrej Fabry <[email protected]> * added memif interface test to tests/integration (#1412) Signed-off-by: Stanislav Chlebec <[email protected]> * Update VPP to 19.08-rc0.666-g9082b43dd (#1413) * Update VPP to 19.08-rc0.666-g9082b43dd Signed-off-by: Ondrej Fabry <[email protected]> * Update VPP to 19.08-rc0.673-ga2e4451db Signed-off-by: Ondrej Fabry <[email protected]> * Fix in Telemetry plugin and improvements for integration tests (#1414) * Add DumpInterface to vppcalls in ifplugin Signed-off-by: Ondrej Fabry <[email protected]> * Cleanup vpp integration tests Signed-off-by: Ondrej Fabry <[email protected]> * Fix file name Signed-off-by: Ondrej Fabry <[email protected]> * Hide iptables warning when no config found Signed-off-by: Ondrej Fabry <[email protected]> * Print shm warning directly into stderr Signed-off-by: Ondrej Fabry <[email protected]> * Fix single interface dump for older VPP Signed-off-by: Ondrej Fabry <[email protected]> * Fix retrieving memory stats in telemetry for VPP 19.08 Signed-off-by: Ondrej Fabry <[email protected]> * Add tests for telemetry to VPP integration tests Signed-off-by: Ondrej Fabry <[email protected]> * Fix integration tests - Skip some telemetry integration tests for VPP<=19.04 - Fix GetMemory in telemetry for VPP<=19.04 - Use hard-coded config for VPP - Use DOCKER_ARGS for custom arguments for docker Signed-off-by: Ondrej Fabry <[email protected]> * Update GoVPP Signed-off-by: Ondrej Fabry <[email protected]> * Fix URL for VPP metrics in telemetry plugin (#1416) * Fix URL for VPP metrics in telemetry plugin Signed-off-by: Ondrej Fabry <[email protected]> * Update Gopkg.lock * Optimize interface state dump for specific interfaces (#1415) * Optimize interface state dump for specific interfaces - define env var for printing debug logs about interface states - extend interface state info in vppcalls for ifplugin - return error when loading config fails - minor improvements for VPP integration testing Signed-off-by: Ondrej Fabry <[email protected]> * Remove obsolete function Signed-off-by: Ondrej Fabry <[email protected]> * Add option for skipping metrics in telemetry plugin (#1417) Signed-off-by: Ondrej Fabry <[email protected]> * Added CRUD integration tests for IPv4/IPv6 (#1419) * Added CRUD integration tests for IPv4/IPv6 routes in default VRF and VRF=2 Signed-off-by: Stanislav Chlebec <[email protected]> * improving code Signed-off-by: Stanislav Chlebec <[email protected]> * removed comments and parametrized value of VRF (vrfMetaIdx) * removed redundant initialisation to default value causes warnings in travis Signed-off-by: Stanislav Chlebec <[email protected]> * Minor enhancements and code cleanups (#1420) * Minor enhancement for transaction summary log Signed-off-by: Ondrej Fabry <[email protected]> * Add make target for remote debugging with delve Signed-off-by: Ondrej Fabry <[email protected]> * Minor code cleanup in vpp ifplugin Signed-off-by: Ondrej Fabry <[email protected]> * Fix error check when renaming tap and cleanup code Signed-off-by: Ondrej Fabry <[email protected]> * Add integration test for IP address (#1421) Signed-off-by: Ondrej Fabry <[email protected]> * added arp crud integration test (#1422) * added arp crud integration test Signed-off-by: Stanislav Chlebec <[email protected]> * comments removed * added more asserts - asserts related to number of arp entries in arp dump - asserting of fields of arp entry - assert non presence in arp dump - hard-coded index replaced by generated one stored in the variable ifIdx Signed-off-by: Stanislav Chlebec <[email protected]> * simplify assert (omitting assert of Static field) Signed-off-by: Stanislav Chlebec <[email protected]> * Update VPP to 19.08-rc0.699-gf7c30df4b (#1424) Signed-off-by: Ondrej Fabry <[email protected]> * kvscheduler: keep node in the graph during recreate (#1423) This patch fixes issues reported in #1418. During recreate (Delete+Create) the node would be completely removed from the graph by Delete and all the associated flags (metadata) were therefore lost. When the subsequent Create fails, the scheduler needs to access the flags, which in this case are undefined, causing the scheduler to panic by dereferencing nil pointer. This patch ensures that the node and its flags are preserved during re-creation. An in-progress refactor of the scheduling algorithm will approach value recreation in a much cleaner way... Signed-off-by: Milan Lenco <[email protected]> * Update VPP to 19.08-rc0.706-ga58fec168 (#1426) Signed-off-by: Ondrej Fabry <[email protected]> * Define VRF as retrieve dependency for routes (#1429) Signed-off-by: Ondrej Fabry <[email protected]> * extend linux plugin (#1431) * add "EXISTING" interface type Signed-off-by: Matus Mrekaj <[email protected]> * update interface descriptor Signed-off-by: Matus Mrekaj <[email protected]> * update interface descriptor Signed-off-by: Matus Mrekaj <[email protected]> * WIP integration test ACL IP CRUD (#1428) * integration test ACL IP rule CRUD Signed-off-by: Stanislav Chlebec <[email protected]> * renamed to 040_acl_test.go Signed-off-by: Stanislav Chlebec <[email protected]> * to satisfy lint Signed-off-by: Stanislav Chlebec <[email protected]> * Trying to loop over acl dump * Looping over IP rule * acl IP rule CRUD almost finished Signed-off-by: Stanislav Chlebec <[email protected]> * acl IP rule CRUD Signed-off-by: Stanislav Chlebec <[email protected]> * satisfy lint * added acl integration test for MAC IP rules fixed comments in interface definition Signed-off-by: Stanislav Chlebec <[email protected]> * fix comments - they should start with space Signed-off-by: Stanislav Chlebec <[email protected]> * create a helper function that returns ACL rule - for IP rule - for IP MAC rule Signed-off-by: Stanislav Chlebec <[email protected]> * acl integration test - refactoring - introducing of helper functions to eliminate declaration of acl_rule variables - removing needless convert with uint32 - simplifying code with expect functions - improving logged messages to improve understanding Signed-off-by: Stanislav Chlebec <[email protected]> * satisfy lint Signed-off-by: Stanislav Chlebec <[email protected]> * Fix Retrieve for TAPv2 interface without Linux-side NB config (#1432) Signed-off-by: Milan Lenco <[email protected]> * Update VPP 19.08 to stable (rc1) Signed-off-by: Ondrej Fabry <[email protected]> * Update VPP 19.08 to stable (rc1) (#1433) Signed-off-by: Ondrej Fabry <[email protected]> * Release v2.2.0-beta Signed-off-by: Ondrej Fabry <[email protected]> * Changelog for vpp-agent v2.2.0-beta Signed-off-by: Vladimir Lavor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problem with detecting IPv6 address reported in issue #1350.