-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: simulator #76
Merged
Merged
feat!: simulator #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module namespace must be `org.module.v1.msg` for the simulator to return the correct module name in the stats.
fmorency
commented
Jun 27, 2024
This PR is ready for a first round of comments. |
Reecepbcups
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just that comment, if that is an acceptable risk (since it would be forking anyways) then approved
[skip_ci]
This was referenced Jul 15, 2024
Ran 6 full app simulators (a735771), in parallel, in a loop, over the weekend. Got 0 failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Breaking change: New Ante Handler disabling
MsgWithdrawDelegatorRewards
I need to set the commission rate floor/ceil during application creation as the POA simulation expects
[0.1, 0.5]
. I'd like to know if there's a better approach to what I did, I don't like it very much.To execute the full app simulation, run
make sim-app-full
TODO