Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simulator #76

Merged
merged 24 commits into from
Jul 22, 2024
Merged

feat!: simulator #76

merged 24 commits into from
Jul 22, 2024

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented Jun 27, 2024

Fixes #72

Breaking change: New Ante Handler disabling MsgWithdrawDelegatorRewards

I need to set the commission rate floor/ceil during application creation as the POA simulation expects [0.1, 0.5]. I'd like to know if there's a better approach to what I did, I don't like it very much.

To execute the full app simulation, run make sim-app-full

TODO

  • Fix determinism
  • Simulate Burn coins
  • Simulate Update params
  • Write migration (maayyybe)

@fmorency fmorency added enhancement New feature or request test labels Jun 27, 2024
@fmorency fmorency self-assigned this Jun 27, 2024
app/app.go Show resolved Hide resolved
@fmorency fmorency marked this pull request as ready for review June 27, 2024 18:33
@fmorency
Copy link
Collaborator Author

This PR is ready for a first round of comments.

Copy link
Collaborator

@Reecepbcups Reecepbcups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just that comment, if that is an acceptable risk (since it would be forking anyways) then approved

app/export.go Outdated Show resolved Hide resolved
[skip_ci]
@fmorency
Copy link
Collaborator Author

Ran 6 full app simulators (a735771), in parallel, in a loop, over the weekend. Got 0 failure.

@fmorency fmorency merged commit 76de251 into liftedinit:main Jul 22, 2024
14 checks passed
@fmorency fmorency deleted the simulator branch July 22, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add simulator support
2 participants