chalabi/mobile on desktop #150
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import React, { MouseEventHandler, useEffect, useMemo, useState, useRef } from 'react'; | ||
|
|
||
| import { ArrowDownTrayIcon, ArrowPathIcon } from '@heroicons/react/24/outline'; | ||
| import { ArrowUpIcon, CopyIcon } from './icons'; | ||
|
|
@@ -37,20 +37,32 @@ | |
| const { connect, openView, status, username, address } = useChain(chainName); | ||
|
|
||
| const [localStatus, setLocalStatus] = useState(status); | ||
| const timeoutRef = useRef<ReturnType<typeof setTimeout>>(); | ||
|
|
||
| useEffect(() => { | ||
| if (status === WalletStatus.Connecting) { | ||
| // Clear any existing timeout | ||
| if (timeoutRef.current) { | ||
| clearTimeout(timeoutRef.current); | ||
| } | ||
|
|
||
| // Set new timeout | ||
| timeoutRef.current = setTimeout(() => { | ||
| setLocalStatus(WalletStatus.Error); | ||
| }, 30000); // 30 seconds timeout | ||
| } else { | ||
| setLocalStatus(status); | ||
| // Clear timeout when status changes | ||
| if (timeoutRef.current) { | ||
| clearTimeout(timeoutRef.current); | ||
| } | ||
| } | ||
|
|
||
| // Cleanup on unmount | ||
| return () => { | ||
| if (timeoutRef.current) { | ||
| clearTimeout(timeoutRef.current); | ||
| } | ||
| }; | ||
| }, [status]); | ||
|
|
||
|
|
@@ -203,7 +215,11 @@ | |
| } | ||
|
|
||
| let onClick; | ||
| if ( | ||
| status === WalletStatus.Disconnected || | ||
| status === WalletStatus.Rejected || | ||
| status === WalletStatus.Error | ||
| ) | ||
| onClick = onClickConnect; | ||
| else onClick = openView; | ||
|
|
||
|
|
@@ -212,12 +228,10 @@ | |
| return ( | ||
| <div className="relative group"> | ||
| <button | ||
| onClick={onClick} | ||
| className={`flex justify-center items-center w-8 h-8 hover:text-primary duration-200 ease-in-out ${ | ||
| status === WalletStatus.Connected ? 'cursor-default' : 'cursor-pointer' | ||
| }`} | ||
| > | ||
| <buttonData.icon className="w-8 h-8" /> | ||
| </button> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ | |
| "@chain-registry/assets": "^1.64.83", | ||
| "@cosmjs/cosmwasm-stargate": "0.32.4", | ||
| "@cosmjs/stargate": "npm:@liftedinit/[email protected]", | ||
| "@cosmos-kit/cosmos-extension-metamask": "^0.12.1", | ||
| "@cosmos-kit/react": "2.18.0", | ||
| "@cosmos-kit/web3auth": "2.11.0", | ||
| "@fontsource/manrope": "^5.0.21", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ import { useEffect, useMemo, useState } from 'react'; | |
| import SignModal from '@/components/react/authSignerModal'; | ||
| import { manifestAssets, manifestChain } from '@/config'; | ||
| import { SignerOptions, wallets } from 'cosmos-kit'; | ||
| import { wallets as cosmosExtensionWallets } from '@cosmos-kit/cosmos-extension-metamask'; | ||
| import { ChainProvider } from '@cosmos-kit/react'; | ||
| import { Registry } from '@cosmjs/proto-signing'; | ||
| import { TailwindModal } from '@/components'; | ||
|
|
@@ -123,6 +124,16 @@ function ManifestApp({ Component, pageProps }: ManifestAppProps) { | |
| name: 'Reddit', | ||
| logo: '/reddit', | ||
| }, | ||
| { | ||
| provider: 'email_passwordless', | ||
| name: 'Email', | ||
| logo: '/email', | ||
| }, | ||
| { | ||
| provider: 'sms_passwordless', | ||
| name: 'SMS', | ||
| logo: '/sms', | ||
| }, | ||
|
There was a problem hiding this comment. 💡 Codebase verification Web3Auth configuration requires additional setup The verification reveals missing critical configuration:
To enable email and SMS authentication:
🔗 Analysis chainVerify email and SMS authentication configuration. The addition of email and SMS authentication methods enhances accessibility, but requires proper configuration to function correctly. Let me gather more information about the Web3Auth configuration and usage in the codebase. Let me check the Web3Auth configuration and initialization code to understand how email and SMS providers are set up. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify Web3Auth configuration for email and SMS providers
# Check for required environment variables and configuration files
# Check if Web3Auth client ID is configured
if ! grep -q "NEXT_PUBLIC_WEB3_CLIENT_ID" .env*; then
echo "Warning: Web3Auth client ID environment variable not found"
fi
# Check Web3Auth configuration in package.json
if [ -f "package.json" ]; then
jq '.dependencies["@web3auth/base"]' package.json
jq '.dependencies["@web3auth/modal"]' package.json
fi
Length of output: 351 Script: #!/bin/bash
# Search for Web3Auth related imports and configurations
echo "=== Searching for Web3Auth related imports ==="
rg "@web3auth" -A 3
echo -e "\n=== Searching for Web3Auth configuration patterns ==="
ast-grep --pattern 'new Web3Auth($$$)'
echo -e "\n=== Checking for environment variable usage ==="
rg "NEXT_PUBLIC_WEB3" -A 2
echo -e "\n=== Looking for configuration files ==="
fd -e config.js -e config.ts
Length of output: 882 Script: #!/bin/bash
# Check Web3Auth configuration and provider setup
echo "=== Checking Web3Auth Modal configuration ==="
rg -A 10 "new Web3Modal"
echo -e "\n=== Looking for provider configurations ==="
rg "provider.*['\"]email_passwordless['\"]|provider.*['\"]sms_passwordless['\"]" -A 5
echo -e "\n=== Checking authentication related functions ==="
ast-grep --pattern 'async function $_($$_) {
$$$
login($$$)
$$$
}'
Length of output: 923 |
||
| ], | ||
|
|
||
| client: { | ||
|
|
@@ -145,7 +156,7 @@ function ManifestApp({ Component, pageProps }: ManifestAppProps) { | |
| ); | ||
|
|
||
| // combine the web3auth wallets with the other wallets | ||
| const combinedWallets = [...web3AuthWallets, ...wallets, ...cosmosExtensionWallets]; | ||
|
|
||
| // this is stop ssr errors when we render the web3auth signing modal | ||
| const [isBrowser, setIsBrowser] = useState(false); | ||
|
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary non-null assertions
The code uses unnecessary non-null assertions (!). Consider using optional chaining instead.
Also applies to: 151-151
🧰 Tools
🪛 Biome (1.9.4)
[error] 147-147: Forbidden extra non-null assertion.
Safe fix: Remove extra non-null assertion.
(lint/suspicious/noExtraNonNullAssertion)
🪛 GitHub Check: codecov/patch
[warning] 147-148: components/react/modal.tsx#L147-L148
Added lines #L147 - L148 were not covered by tests