-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bits of build file Gardening #1950
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
486ed42
Update API doc link
farmdawgnation 0d79f9a
Bump Scala 2.12 release to 2.12.6
farmdawgnation d60e855
Commons-codec -> 1.11, commons-fileupload -> 1.3.3
farmdawgnation 5daa8f4
Bump joda-time to 2.10
farmdawgnation 24727e3
Bump joda-convert to 2.0.2
farmdawgnation d2f8044
Bump htmlparser to 1.4.11
farmdawgnation cd2a9ca
Bump mongodb drivers to 3.7.1
farmdawgnation f83501b
Bump scalaz-core to 7.2.24
farmdawgnation dabcb11
Bump slf4j version to 1.7.25
farmdawgnation df0070e
Bump scala-xml to 1.0.6
farmdawgnation 8ccfb5f
Bump rhino to 1.7.10
farmdawgnation 923f303
Bump parser combinators to 1.1.0
farmdawgnation 5c25676
Group provided deps
farmdawgnation 56c4a4e
Bump joda-convert to 2.1
farmdawgnation 54c3fee
Revert htmlparser version bump
farmdawgnation c1e31ca
Return parser combinators to their previous version
farmdawgnation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was a million years ago but any idea for the reason behind it?
No biggie -- I'm just currently in the flail-in-the-dark phase of bumping us to Lift 3.4.3 and am going error by eror 😅 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of this PR was just getting us up to date with regard to our outdated dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iiiiinterestingly enough:
we upgraded to lift 3.3 and our tests started failing. adding
exclude("org.mozilla", "rhino"),
to our lift dependencies got 'em to pass O___o.not sure if we're just postponing the inevitable but i found it noteworthy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what got me asking about why this updated dependency -- we were only successful after we reverted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that you have other dependencies that rely on there being an older version of rhino present and Lift bringing in a newer version transitively causes issues for you. I'd recommend taking a look at what other dependencies might ask for Rhino (or look for any direct dependencies on it in your project) to try and determine whether or not that's what is happening. If you use Rhino directly, there's a good chance you'll have code to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is direct usage in that codebase fwiw 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh yeah. I think that's why it the
exclude
worked, yah?I suppose I expected something Rhino-y in this PR. That is, instead of just bumping a version, maybe something like
rhino.oldFunction -> rhino.newFunction
. On the other hand, version bumps to stay current -- with no code changes -- are also legit.'preciate it :D Suppose I might have to Actually Dig In:tm: & learn myself some Clojure 😎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caveat -- I say "Clojure" 'cause I think that's how we're using it. Prolly shoulda read the README first 😅 .