This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Uses title HTML tag whenever is possible to update the page title. Closes #185 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fernandosouza I don't believe this passes the tests of or a test like it('should handle html entities in setting the title', (done) => {
var screen = new HtmlScreen();
screen.load('/url').then(() => {
assert.strictEqual('< > &', screen.getTitle());
done();
});
this.requests[0].respond(200, null, '<title>< > &</title>');
}); |
| @@ -1106,7 +1106,14 @@ class App extends EventEmitter { | |||
| } else { | |||
| globals.window.history.pushState(state, title, path); | |||
| } | |||
| globals.document.title = title; | |||
|
|
|||
| let titleNode = globals.document.querySelector('head title'); | |||
There was a problem hiding this comment.
Only document.querySelector('title'); is enough here
|
You are right @SpencerWoo. I'm going to fix the implementation. Thank you. |
fernandosouza
force-pushed
the
title-tag
branch
from
a65aeaf
to
bffc8ae
Compare
|
Pull updated. @eduardolundgren, please don't merge yet. I'm going to send another pull making Travis run the tests over Saucelabs for PRs. |
fernandosouza
force-pushed
the
title-tag
branch
from
bffc8ae
to
7a91e9e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.