-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for svg icons #74
Changes from 9 commits
789c087
239dea4
03f7eca
edddb32
c7c6a5c
c81cb21
a0886cf
e8b036f
192a1fe
caf9940
abd14ca
8119936
3723b95
7d214a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
.cke_hidpi .cke_button_icon { | ||
background-size: 16px !important; | ||
background-position: center !important; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,36 +4,59 @@ | |
"align-image-center": "align-image-center", | ||
"align-image-left": "align-image-left", | ||
"align-image-right": "align-image-right", | ||
"anchor": "flag-full", | ||
"anchor": { | ||
"ltr": "flag-full" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here... why just I just have no idea what this is supposed to do, it just feels weird :D There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as the others |
||
}, | ||
"blockquote": "quote-right", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this one be directional as well? :D There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is but we don't have the rtl icon yet. I can use the same until we have it or just leave it blank. |
||
"bold": "bold", | ||
"bulletedlist": "list-ul", | ||
"bulletedlist": { | ||
"ltr": "list-ul" | ||
}, | ||
"copy": "paste", | ||
"cut": "cut", | ||
"find": "search", | ||
"find": { | ||
"ltr": "search", | ||
"rtl": "search" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this mean to be a different There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, CKEditor have it as directional so we need to specify the icon for both directions. Probably we'll need to specify other icon, something like |
||
}, | ||
"hidden": "hidden", | ||
"horizontalrule": "separator", | ||
"image": "picture", | ||
"indent": "indent-more", | ||
"indent": { | ||
"ltr": "indent-more", | ||
"rtl": "indent-less" | ||
}, | ||
"italic": "italic", | ||
"justifyblock": "align-justify", | ||
"justifycenter": "align-center", | ||
"justifyleft": "align-left", | ||
"justifyright": "align-right", | ||
"link": "link", | ||
"maximize": "full-size", | ||
"numberedlist": "list-ol", | ||
"outdent": "indent-less", | ||
"redo": "redo", | ||
"numberedlist": { | ||
"ltr": "list-ol" | ||
}, | ||
"outdent": { | ||
"ltr": "indent-less", | ||
"rtr": "indent-more" | ||
}, | ||
"redo": { | ||
"ltr": "redo", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure these are directional? It kinda makes sense... but I'd love to get some reading about it :D There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CKEditor have it as directional (automatically uses |
||
"rtl": "undo" | ||
}, | ||
"removeformat": "remove-style", | ||
"replace": "change-list", | ||
"source": "code", | ||
"source": { | ||
"ltr":"code" | ||
}, | ||
"strike": "strikethrough", | ||
"subscript": "subscript", | ||
"superscript": "superscript", | ||
"table": "table2", | ||
"underline": "underline", | ||
"undo": "undo", | ||
"undo": { | ||
"ltr": "undo", | ||
"rtl": "redo" | ||
}, | ||
"unlink": "chain-broken" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this comment is no longer acurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upsy