chore: Prepare for release 4.13.1-liferay.4 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
reviewed
Mar 25, 2020
| @@ -25,5 +25,5 @@ index aa32f0de5..289684816 100644 | |||
| return; | |||
|
|
|||
| -- | |||
| 2.25.0 | |||
| 2.17.1 | |||
There was a problem hiding this comment.
You really should upgrade 😂
|
@julien: Just a thought which I should have had when reviewing this. In the future we should merge one PR to add the patch and then do the release. Because otherwise we wind up with a changelog that has an entry in it like "chore: Prepare for release 4.13.1-liferay.4" and no mention of the actually interesting thing, which is that we fixed a bug. |
|
@wincent yeah that makes sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.