docs: update CHANGELOG with new version of liferay-changelog-generator #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerating to make sure these two pulls to the generator are good before publishing a new release: - liferay/liferay-npm-tools#398 - liferay/liferay-npm-tools#399 So this is just a test of those, done with: ../liferay-npm-tools/packages/liferay-changelog-generator/bin/liferay-changelog-generator.js \ --from=v4.11.3-liferay.0 \ --to=v4.13.1-liferay.3 \ --version=v4.13.1-liferay.3 \ --regenerate \ --force
Comparing the effect of running `yarn format` in this repo with others, it was changing the indent of bullet lists in our CHANGELOG in a way that doesn't match the other repos. This is a problem because we have tuned the output of liferay-changelog-generator to match what `prettier format` expects — so we need it to behave exactly the same in all repos. This commit adds the minimal config necessary to make the Markdown output match, but note that because it is repo-wide, it also affects the JS and JSON files, which seems fine.
|
Just a doc update, so going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerating to make sure these two pulls to the generator are good before publishing a new release:
So this is just a test of those, done with:
See the second commit message for an explanation of why we need to tweak the Prettier settings (the short version: to make the changelog format match what we use in other repos).