docs: apply miscellaneous updates #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two days in a row now I've had trouble building the
frontend-editor-ckeditor-web module in liferay-portal after a `yarn
add`. Yesterday it was freaking out with:
```
> Ambiguous method overloading for method java.io.File#<init>.
Cannot resolve which method to invoke for [null, class java.lang.String] due to overlapping prototypes between:
[class java.lang.String, class java.lang.String]
[class java.io.File, class java.lang.String]
```
caused by `packageRunBuild.destinationDir` in the build.gradle file
somehow being `null`.
Today, it's:
```
Error: ENOENT: no such file or directory, open 'node_modules/liferay-ckeditor/package.json'
at Object.openSync (fs.js:439:3)
```
Yet, when I inspect the `node_modules` folder everything is golden.
In both cases, things work fine when I do then manual `cp -R` instead of
the `yarn add`. Whatever the cause, may as well document the workaround.
We're using Yarn on 7.1.x now too. Only 7.0.x hasn't gotten with the program yet.
|
As it's just doc updates and I've proof-read them, going to merge. Can apply follow-ups later if any feedback comes in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updates made while testing prior to release.