LPD-34946 Check if values are empty and delete styles when not used #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit autogenerated with "./ck.sh".
|
Thank you @bryceosterhaus! Thank you! |
markocikos
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPP-55392
https://liferay.atlassian.net/browse/LPD-34946
Hello,
Using the Image Properties, the image gets
style="margin: 0px;”added. This is no longer removable even if the entries are empty.Before
Screencast from 08-27-2024 01:36:12 PM.webm
I made changed so that the styles are removed and no longer added if the entries are blank.
After
Screencast.from.08-27-2024.01.27.16.PM.webm
Let me know if there are any questions or comments about this.
Thank you!