fix: LPS-165655 Disable tab key by default to avoid the focus to be t… #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapped in the editor
dsanz
reviewed
Oct 25, 2022
| : editor.lang.codemirror.enableTabKeyUsing; | ||
|
|
||
| var html = | ||
| '<div class="keyboard-message popover px-2 py-1" style="left:auto; right: 4px; top:4px">'; |
There was a problem hiding this comment.
This introduces some clay-css dependencies, whick may not be available in all cases when using the editor in non-admin contexts. The bigger issue seems with the popover class as it defines the zindex and positioning.
Probably with some inlining this can be worked around
There was a problem hiding this comment.
I'm merging this with the commitment of coming back and:
- review styling, as per the dependency with clay-css
- review solution design as the popover overlaps the editable area, as implemened in other codemirrors across DXP
- translate the messages as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rapped in the editor
Also, user can press CTRL + M to enable tabs in the editor.
This is the same solution we used to fix other similar cases: https://issues.liferay.com/browse/LPS-164875