chore: update ckeditor-dev to 4.18.0 #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ckeditor4 changelog: https://github.com/ckeditor/ckeditor4/blob/master/CHANGES.md#ckeditor-4180 Web Spell Checker ended support for WebSpellChecker Dialog on December 31st, 2021. This means the plugin is not supported any longer. Therefore, we decided to deprecate and remove the WebSpellChecker Dialog plugin from CKEditor 4 presets.
5fe059002f (tag: 4.18.0) Merge pull request #5129 from ckeditor/changelog-4.18
…rsion of ckeditor
markocikos
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It updates ckeditor's base version to 4.18.0 to solve errors like:
when navigating from a page that an editor was mounted to another one.
There is a ticket for it: https://issues.liferay.com/browse/LPS-149452
Things to keep an eye(or maybe both eyes)
When I ran
./ck.sh build, I got some errors about wsc not being available to download, and when I checked the ckeditor changelog, I discovered they had removed/deprecated wsc.I needed to remove this LOC where it was responsible for downloading wsc in order for the build script to run properly.
About wsc depending usages:
I noticed we're setting some styles/skin on moono-lexicon related to wsc plugin. So, I removed this CSS file
When grepping around DXP, I identified only an import thing related to testing at this file where tests are trying to assert if wsc plugin was downloaded or not. After talking with @john-co, We decided to just remove it because it was unused.
There is a ticket for it as a sub task: https://issues.liferay.com/browse/LPS-150162