fix: make text wrap in codemirror plugin #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [5de7cdb](liferay/liferay-portal@5de7cdb), and [1783acf](liferay/liferay-portal@1783acf) we intended to fix line wrapping in the codemirror (source view) plugin but this was apparently missing **Test plan**: - Fetch this branch and build `liferay-ckeditor` with ```sh ./ck.sh build ``` - Use the previously built version of `liferay-ckeditor` in DXP - Deploy the `frontend-editor-ckeditor-web` OSGi module - Navigate to **Instance Settings** > **Email** - Assert that the editors wrap text correctly
The links are broken (porting at liferay-portal instead of this repo). If you just go with SHA-1s, GitHub will autolink them anyway; eg: (And abbreviate them... those are just 40-char SHA-1 hashes, but GitHub shortens them when rendering.) |
wincent
approved these changes
Oct 13, 2020
|
@wincent thanks I've fixed those links |
|
going to merge this and prepare a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
5de7cdband1783acfwe intended to fix text wrapping in thecodemirror(source view) plugin but this was apparently missingTest plan:
Fetch this branch and build
liferay-ckeditorwithUse the previously built version of
liferay-ckeditorin DXPDeploy the
frontend-editor-ckeditor-webOSGi moduleNavigate to Instance Settings > Email
Assert that the editors wrap text correctly
Before
After