Icon links and buttons need to have a title to show a tooltip | Fixes #972 #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloslancha
changed the title
Pull Request Test Coverage Report for Build 887
💛 - Coveralls |
|
@matuzalemsteles, could you please take a look here? 👍 |
|
Just started reviewing :) |
Sent from
|
LGTM! hey @carloslancha, It seems that the tooltip has some bugs when it is passed the mouse over it does the wrong calculation and the second time, fixes... |
|
Hi @matuzalemsteles yep, I already reported it when we merged the component. If you want to take a look would be helpful ;) Thx! |
|
Ah yeah, I had not seen it, sorry 😅. I can take a look at this tomorrow 🙂. |
jbalsas
reviewed
Jun 8, 2018
| if (titleTag) { | ||
| target.setAttribute('data-title', titleTag.innerHTML); | ||
| target.setAttribute('data-restore-title', 'true'); | ||
| titleTag.remove(); |
There was a problem hiding this comment.
Do we really need to do this for svgs? The only reason we remove the title attribute is to make sure it doesn't show the default tooltip. Does it also happens for svgs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.