Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement predictive Chart #818

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Implement predictive Chart #818

merged 1 commit into from
Apr 19, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Apr 19, 2018

No description provided.

@julien julien requested a review from jbalsas April 19, 2018 10:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 630

  • 32 of 48 (66.67%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 81.961%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/clay-charts/src/ChartBase.js 4 6 66.67%
packages/clay-charts/src/PredictiveChart.js 16 30 53.33%
Totals Coverage Status
Change from base Build 624: 0.05%
Covered Lines: 4874
Relevant Lines: 5153
💛 - Coveralls

@jbalsas
Copy link
Contributor

jbalsas commented Apr 19, 2018

Cool!

@jbalsas jbalsas merged commit 32055fe into liferay:develop Apr 19, 2018
@julien julien deleted the issue-813 branch April 19, 2018 10:43
@julien julien mentioned this pull request Apr 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbalsas jbalsas Awaiting requested review from jbalsas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julien @coveralls @jbalsas