Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render unnecessary custom-control-label-text on other components in ClayCheckbox #451

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

matuzalemsteles
Copy link
Member

In use cases like ClayCard when it is not necessary to pass $label it is rendered unnecessarily. Only by placing inside the {if} conditional so that they are not rendered in these use cases. What do you think?

{let $spanLabelClasses kind="text"}
	custom-control-label-text
	{if $hideLabel}
		{sp}sr-only
	{/if}
{/let}

<span class="{$spanLabelClasses}">{$label}</span>

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha
Copy link
Contributor

LGTM!

@jbalsas jbalsas merged commit 0ba86ea into liferay:develop Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants