Add labels to management toolbar results bar | Fixes #1112 #1130
Conversation
carloslancha
changed the title
Pull Request Test Coverage Report for Build 1137
💛 - Coveralls |
|
Just started reviewing :) |
Sent from 
| <div class="tbar-section"> | ||
| {foreach $filterLabel in $filterLabels} | ||
| {call ClayLabel.render} | ||
| {param closeable: $filterLabel.closeable == false ? false : true /} |
There was a problem hiding this comment.
Could this be summed up like this?
{param closeable: $filterLabel.closeable ?: true /}| const filterLabelsValidator = Config.arrayOf( | ||
| Config.shapeOf({ | ||
| closeable: Config.bool().value(true), | ||
| label: Config.string(), |
There was a problem hiding this comment.
hey @carloslancha maybe we have to add in ClayLabel to support HTML in the label API so you can customize it as defined below.
| /** | ||
| * This renders de clear results button or link | ||
| */ | ||
| {template .clearResults} |
There was a problem hiding this comment.
I think we should make this a deltemplate so this can make it an extension point so people can cover cases like this:
Maybe rename it to something more general, something like ResultsAction.
There was a problem hiding this comment.
If this is a need please open an issue and we can add it later, I prefer do not mix issues here :)
|
hey @carloslancha is this ready to be merged or are you waiting for Patrick to make markup corrections? |
|
Hey @matuzalemsteles we can merge this and update the markup once Patrick has made it. Thx! |
No description provided.