Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons don't have the proper viewport 0 0 512 512 #979

Closed
jbalsas opened this issue Jun 8, 2018 · 6 comments
Closed

Some icons don't have the proper viewport 0 0 512 512 #979

jbalsas opened this issue Jun 8, 2018 · 6 comments
Labels
status: next-release Issues that will enter into the next release

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Jun 8, 2018

We currently have some icons that don't follow our guidelines regarding the viewport attribute:

icon viewport
add-role 0 0 22 23.68
calendar 0 0 511.4 512
date 0 0 511.4 512
download 0 0 384 512
dynamic-data-list 0 0 448 512
flags-et-EE 0 0 32 24
flags-th-TH 0 0 32 24
format 0 0 448 512
list-ol 0 0 16 16
mark-as-answer 0 0 416 448
mark-as-question 0 0 416 448
mobile-landscape 0 0 384 288
mobile-portrait 0 0 384 288
remove-role 0 0 22 23.68
reply 0 0 320 255.9961
share 0 0 448 448
tablet-landscape 0 0 416 352
tablet-portrait 0 0 352 416
trash 0 0 384 513

@pat270, can you take care of normalizing these, please? It is causing some rendering issues when used in combination with other things :D

@emiliano-cicero
Copy link

trash-svg.zip

Hey @marcoscv @jbalsas I included the trash svg, could you try if it work?

@emiliano-cicero
Copy link

fixed-icons.zip

@jbalsas @marcoscv these are all the fixed icons and flags from the list, excluding the trash that was included in the previous comment.
Thank you in advance!

@jbalsas
Copy link
Contributor Author

jbalsas commented Jun 11, 2018

Thanks a lot @emiliano-cicero!! @pat270, could you process these when you have time? You know better than us the changes needed for them to follow our guidelines 👍

@emiliano-cicero
Copy link

hey @pat270, I inverted the name of the "add-role" and "remove-role" to "role-add" and "role-remove", this way the icons will be close to each other. Thanks!

@pat270
Copy link
Member

pat270 commented Jun 11, 2018

@emiliano-cicero @jbalsas The rename would be a breaking change, you guys ok with that?

@jbalsas
Copy link
Contributor Author

jbalsas commented Jun 11, 2018

Not really, no 😂

The pattern is also add-* and remove-*, which makes more sense from the usage point of view, so I think I'd rather keep it.

pat270 added a commit to pat270/clay that referenced this issue Jun 11, 2018
…wnload`, `dynamic-data-list`, `flags-et-EE`, `flags-th-TH`, `format`, `list-ol`, `mark-as-answer`, `mark-as-question`, `mobile-landscape`, `mobile-portrait`, `reply`, `add-role`, `remove-role`, `share`, `tablet-landscape`, `tablet-portrait` to have consistent viewBox attribute with other icons
jbalsas added a commit that referenced this issue Jun 12, 2018
Update: (Fixes #979) Lexicon SVG Icons `calendar`, `date`, `download`…
@jbalsas jbalsas added the status: next-release Issues that will enter into the next release label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Development

No branches or pull requests

3 participants