-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some icons don't have the proper viewport 0 0 512 512 #979
Comments
Thanks a lot @emiliano-cicero!! @pat270, could you process these when you have time? You know better than us the changes needed for them to follow our guidelines 👍 |
hey @pat270, I inverted the name of the "add-role" and "remove-role" to "role-add" and "role-remove", this way the icons will be close to each other. Thanks! |
@emiliano-cicero @jbalsas The rename would be a breaking change, you guys ok with that? |
Not really, no 😂 The pattern is also |
…wnload`, `dynamic-data-list`, `flags-et-EE`, `flags-th-TH`, `format`, `list-ol`, `mark-as-answer`, `mark-as-question`, `mobile-landscape`, `mobile-portrait`, `reply`, `add-role`, `remove-role`, `share`, `tablet-landscape`, `tablet-portrait` to have consistent viewBox attribute with other icons
Update: (Fixes #979) Lexicon SVG Icons `calendar`, `date`, `download`…
We currently have some icons that don't follow our guidelines regarding the
viewport
attribute:@pat270, can you take care of normalizing these, please? It is causing some rendering issues when used in combination with other things :D
The text was updated successfully, but these errors were encountered: