Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClayComponent.getAttribute does not respect the spec when the attribute has no value #715

Closed
4lejandrito opened this issue Mar 12, 2018 · 0 comments
Closed

ClayComponent.getAttribute does not respect the spec when the attribute has no value #715

4lejandrito opened this issue Mar 12, 2018 · 0 comments
Assignees
@carloslancha

Comments

@4lejandrito
Copy link
Member

the spec says that the return value must be the empty string when the attribute has no value.

However, clay returns undefined when there is no value for an attribute. This makes tools like Alloy UI to get confused and malfunction in some weird corner cases that @carloslancha has witnessed with me.

More info at https://developer.mozilla.org/en-US/docs/Web/API/Element/getAttribute#Notes.
@carloslancha carloslancha self-assigned this Mar 13, 2018
jbalsas added a commit that referenced this issue Mar 13, 2018
@jbalsas
Merge pull request #720 from carloslancha/pr-716
18ca1d0 
Returning empty string when no attribute is present | Fixes #715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carloslancha carloslancha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4lejandrito @carloslancha