-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ClaySelect Markup #558
Labels
status: next-release
Issues that will enter into the next release
Comments
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
matuzalemsteles
added a commit
to matuzalemsteles/clay
that referenced
this issue
Feb 15, 2018
carloslancha
added a commit
that referenced
this issue
Feb 16, 2018
Update ClaySelect markup and remove wrapperType to use the inline API| Fixes #558
carloslancha
added
the
status: next-release
Issues that will enter into the next release
label
Feb 16, 2018
kienD
pushed a commit
to kienD/clay
that referenced
this issue
Feb 21, 2018
kienD
pushed a commit
to kienD/clay
that referenced
this issue
Feb 21, 2018
kienD
pushed a commit
to kienD/clay
that referenced
this issue
Feb 21, 2018
kienD
pushed a commit
to kienD/clay
that referenced
this issue
Feb 21, 2018
kienD
pushed a commit
to kienD/clay
that referenced
this issue
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The class
.form-inline-group
was renamed to.form-group-item
in v2.0.0-beta.5 December 25, 2017. Hey @pat270 let me know if I'm wrong about this.I do not know if it does but feel we have the
wrapperType
API, maybe we can just go with aninline
to true to add the.form-group-item
class. This way it does not risk breaking an API when a markup change and does not depend on the API input.Current
New
I do not know if it's the best time to change the API. What do you think? @carloslancha
The text was updated successfully, but these errors were encountered: