Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE: Tabbing through the document focuses SVG elements #536

Closed
pat270 opened this issue Feb 8, 2018 · 4 comments
Closed

IE: Tabbing through the document focuses SVG elements #536

pat270 opened this issue Feb 8, 2018 · 4 comments
Assignees
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@pat270
Copy link
Member

pat270 commented Feb 8, 2018

Clay SVG's need the attribute focusable="false"

@pat270 pat270 self-assigned this Feb 8, 2018
@jbalsas jbalsas added the type: bug Issues reporting that Component is not doing what should be done label Feb 9, 2018
@pat270 pat270 removed their assignment Feb 13, 2018
@matuzalemsteles
Copy link
Member

hey @pat270 focusable="false" is for all use cases? ClayIcon?

@pat270
Copy link
Member Author

pat270 commented Feb 15, 2018

@matuzalemsteles, yes I think so. Anytime you would want it to be focusable, it would be wrapped in a button, anchor, or the element would have tabindex="0". The only case I can think of (where you don't want focusable="false") is if you bind a js user event directly to the svg.

@carloslancha
Copy link
Contributor

Let's just add a param focusable to the state with default value false, just in case we need it to be true in some case ;)

@matuzalemsteles
Copy link
Member

Thanks @pat270 for the clarifying!

@carloslancha, sound good.

@matuzalemsteles matuzalemsteles self-assigned this Feb 15, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 15, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 15, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 16, 2018
carloslancha added a commit that referenced this issue Feb 16, 2018
Add flag to indicate if svg is focusable or not | Fixes #536
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label Feb 16, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

4 participants