Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create data API to replace columns in Charts #526

Closed
jbalsas opened this issue Feb 8, 2018 · 0 comments
Closed

Create data API to replace columns in Charts #526

jbalsas opened this issue Feb 8, 2018 · 0 comments
Assignees
@julien
Labels
type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Feb 8, 2018

The columns API is very framework/implementation specific and leaves very little room to the imagination.

I propose we:

  • Deprecate columns in all charts as an API
  • Add data as an API that would be passed down to the underlying columns billboard attribute when appropriate and that could receive:
    • An object with the data
    • A string with a URI endpoint to fetch the data
    • A method that returns a promise that gets resolved with the data
@julien julien self-assigned this Feb 8, 2018
@jbalsas jbalsas added the type: enhancement Issues that are open to bring improvements or refinement of code label Feb 9, 2018
@jbalsas jbalsas mentioned this issue Feb 9, 2018
Closed
julien pushed a commit to julien/clay that referenced this issue Feb 12, 2018
Create data API to replace columns in Charts
98a0e3b 
Fixes liferay#526
julien pushed a commit to julien/clay that referenced this issue Feb 13, 2018
Create data API to replace columns in Charts
f823902 
Fixes liferay#526

Add polling_interval option to Charts
Fixes liferay#544
julien pushed a commit to julien/clay that referenced this issue Feb 20, 2018
Create data API to replace columns in Charts
b82713f 
Fixes liferay#526
@julien julien mentioned this issue Feb 20, 2018
Closed
julien pushed a commit to julien/clay that referenced this issue Feb 20, 2018
Create data API to replace columns in Charts
2b4eaef 
Fixes liferay#526
julien pushed a commit to julien/clay that referenced this issue Feb 23, 2018
Create data API to replace columns in Charts
82b5d14 
Fixes liferay#526
julien pushed a commit to julien/clay that referenced this issue Feb 23, 2018
Create data API to replace columns in Charts
2848745 
Fixes liferay#526
@julien julien mentioned this issue Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien julien

Labels
type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julien @jbalsas