Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown.Section is not documented on ClayDropDown API docs #4095

Closed
1 task done
diegonvs opened this issue May 25, 2021 · 6 comments · Fixed by #4108
Closed
1 task done

Dropdown.Section is not documented on ClayDropDown API docs #4095

diegonvs opened this issue May 25, 2021 · 6 comments · Fixed by #4108
Labels
comp: documentation Issues related to documentation in general, be clayui.com or other means... type: bug Issues reporting that Component is not doing what should be done

Comments

@diegonvs
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

What are the steps to reproduce?

Go to https://clayui.com/docs/components/drop-down/api.html#dropdown and search for ClayDropdown.Section API

@diegonvs diegonvs added the type: bug Issues reporting that Component is not doing what should be done label May 25, 2021
@matuzalemsteles matuzalemsteles added the comp: documentation Issues related to documentation in general, be clayui.com or other means... label May 25, 2021
@julien
Copy link
Contributor

julien commented May 31, 2021

@diegonvs I checked that and you're right it's missing
However, when I add

## DropDown.Section

<div>[APITable "clay-drop-down/src/Section.tsx"]</div>

to the api-dropdown.mdx file, nothing happens. I'm not sure why, so I'll see if I can do anything about it.

@diegonvs
Copy link
Contributor Author

Hey @julien, This error comes from reactjs/react-docgen#352 I guess. Taking a look deeply I saw they already merged a solution in the end of last year(here: reactjs/react-docgen#464). Would be interesting to bump the version of react-docgen here and see if it solves :p

@julien
Copy link
Contributor

julien commented May 31, 2021

This error ...

The funny thing is that there is no error, but sure, I'll update that package and see what happens

@diegonvs
Copy link
Contributor Author

diegonvs commented May 31, 2021

I'll update that package and see what happens

@julien
Copy link
Contributor

julien commented May 31, 2021

@diegonvs I'm still seeing this

2021-05-31-17:34:08

And what's a bit more "scary" is this

2021-05-31-17:36:17

that's the only thing happening for me after updating to react-docgen: 5.4.0

@github-actions
Copy link

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: documentation Issues related to documentation in general, be clayui.com or other means... type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants