Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels padding to be fixed #1229

Closed
victorvalle opened this issue Oct 10, 2018 · 2 comments
Closed

Labels padding to be fixed #1229

victorvalle opened this issue Oct 10, 2018 · 2 comments
Labels
status: next-release Issues that will enter into the next release

Comments

@victorvalle
Copy link

victorvalle commented Oct 10, 2018 •
edited
Loading

Could you fix the labels' padding, please?

image

Thanks!
@pat270
Copy link
Member

pat270 commented Oct 12, 2018

@victorvalle I can change the horizontal padding to be 4px and 8px respectively, but the vertical padding doesn't make sense.
Small label height: 10px + 4px + 4px + 1px + 1px = 20px
Large label height: 15px + 8px + 8px + 1px + 1px = 33px

@victorvalle
Copy link
Author

Change the horizontal, that is what makes sense and what we are requesting. Sorry for not specifying more. I thought it was clear. Sorry for the misunderstanding.

Thanks @pat270 !

jbalsas added a commit that referenced this issue Oct 16, 2018
@jbalsas
Merge pull request #1232 from pat270/clay-1229
6fe4055 
Fixes #1229 - Atlas Label and Label Lg make horizontal padding .25rem…
@pat270 pat270 added the status: next-release Issues that will enter into the next release label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat270 @victorvalle