[clay-charts] "xs" is missing from the state declaration of ChartBase

[kienD]

config.xs should be equal to state.xs but we do not declare "xs" in the state of ChartBase.

clay/packages/clay-charts/src/ChartBase.js

Lines 335 to 354 in c01e3e4

	const config = {
	color: state.colorFormatter,
	colors: colors,
	empty: state.emptyLabelText,
	groups: state.groups,
	hide: state.hide,
	json: state.json,
	keys: state.keys,
	labels: state.labels,
	mimeType: state.mimeType,
	order: state.order,
	rows: state.rows,
	selection: state.selection,
	type: state.type,
	url: state.url,
	x: state.x,
	xFormat: state.xFormat,
	xLocaltime: state.xLocaltime,
	xSort: state.xSort,
	xs: state.xs,

clay/packages/clay-charts/src/ChartBase.js

Lines 1410 to 1437 in c01e3e4

	* @default undefined
	* @instance
	* @memberof ChartBase
	* @type {?(boolean|undefined)}
	*/
	xLocaltime: Config.bool(),
	/**
	* Sets billboard's data.xSort config.
	* @default undefined
	* @instance
	* @memberof ChartBase
	* @type {?(Object|undefined)}
	*/
	xSort: Config.bool(),
	/**
	* Configuration for bb chart zoom capabilities.
	* @default undefined
	* @instance
	* @memberof ChartBase
	* @type {?(Object|undefined)}
	*/
	zoom: Config.shapeOf({
	enabled: Config.bool().value(true),
	rescale: Config.bool().value(false),
	extent: Config.array(),
	}),

[julien]

Hi @kienD,

Thanks for reporting this!

I know the code might be a bit confusing but we actually map x to xs in ChartBase, which might have been a good idea some at some point.

See:

clay/packages/clay-charts/src/ChartBase.js

Lines 8 to 16 in 1a70358

	const PROP_NAME_MAP = {
	axis: 'axes',
	class: 'classes',
	color: 'colors',
	name: 'names',
	regions: 'regions',
	type: 'types',
	x: 'xs',
	};

And:

clay/packages/clay-charts/src/ChartBase.js

Lines 300 to 303 in 1a70358

	config[PROP_NAME_MAP[key]] =
	config[PROP_NAME_MAP[key]] || {};
	config[PROP_NAME_MAP[key]][id] = column[key];

But it appears that x and xs expect different types (String vs Object), so you're right, we need to add xs in ChartBase and stop "mapping" xs to x automatically.

Thanks