LPD-42706 #6133

jkappler · 2024-11-28T08:56:19Z

Incorrect user shown in some views

What is this trying to solve?

In some views we show the user that created the entry instead of the one that modified it, this creates a confusion with the clients

How am I fixing it?

Where we have the status, use the user that modified the entry, in other cases, just show the time when it was modified

liferay-continuous-integration · 2024-11-28T08:56:25Z

CI is automatically triggering the following test suites:

ci:test:sf

jkappler · 2024-11-28T08:59:38Z

@adolfopa, I'm unsure of the approach. Another one would be to change all the related update methods in the service to update userId and userName to the user that's modifying the entry

liferay-continuous-integration · 2024-11-28T09:06:20Z

❌ ci:test:sf - 0 out of 1 jobs passed in 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d71b1f9b8213c734d0eca46f7ca2f0c6e6ecbc45

Sender Branch:

Branch Name: LPD-42706_message
Branch GIT ID: d53fff72aa5eb3efa9c92b7ac3f97b31f5bdfff3

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

format-source-files:
     [java] java.lang.Exception: Found 2 formatting issues:
     [java] 1: ./modules/apps/message-boards/message-boards-web/src/main/java/com/liferay/message/boards/web/internal/display/context/MBDisplayContext.java expected:<...opyrightText: (c) 20[24] Liferay, Inc. https...> but was:<...opyrightText: (c) 20[00] Liferay, Inc. https...>
     [java] 2: ./modules/apps/knowledge-base/knowledge-base-web/src/main/resources/META-INF/resources/admin/view_descriptive.jsp expected:<....getModifiedDate();
     [java] [            %>
     [java] 
     [java]             <liferay-ui:message arguments="<%= LanguageUtil.getTimeDescription(request, System.currentTimeMillis() - modifiedDate.getTime(), true)] %>" key="modified-x...> but was:<....getModifiedDate();
     [java] [
     [java]             String modifiedDateDescription = LanguageUtil.getTimeDescription(request, System.currentTimeMillis() - modifiedDate.getTime(), true);
     [java]             %>
     [java] 
     [java]             <liferay-ui:message arguments="<%= modifiedDateDescription] %>" key="modified-x...>
     [java] 
     [java]   at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:472)
     [java]   at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:301)
[stopwatch] [run.batch.test.action: 2:06.809 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:497: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:650: Java returned: 1
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null139062917.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[beanshell] Truncating errors in /opt/dev/projects/github/liferay-portal/portal-impl/test-results/TEST-JenkinsLogAssertTest.xml

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null578634514

[junitreport] Loading stylesheet ile:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 148ms

[junitreport] Deleting: /tmp/null578634514

liferay-continuous-integration · 2024-11-28T09:09:50Z

Jenkins Build:test-portal-source-format#10718

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6133

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jkappler > liferay-content-management - PR#6133 - 2024-11-28[00:56:34]

Testray Build ID:79842146

Testray Importer:publish-testray-report#40834

…fied label based on a message

… only when the entry was modified to avoid confusion

…nly when the entry was modified to avoid confusion

…he entry was modified to avoid confusion

…en the entry was modified to avoid confusion

jkappler · 2024-11-28T09:21:19Z

ci:test:sf

liferay-continuous-integration · 2024-11-28T09:26:05Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d71b1f9b8213c734d0eca46f7ca2f0c6e6ecbc45

Sender Branch:

Branch Name: LPD-42706_message
Branch GIT ID: 7536f5a04ebab9090d95f2b8355db076d7d7c993

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2024-11-28T09:30:13Z

Jenkins Build:test-portal-source-format#6854

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-content-management#6133

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - jkappler > liferay-content-management - PR#6133 - 2024-11-28[01:21:29]

Testray Build ID:79843251

Testray Importer:publish-testray-report#26109

adolfopa · 2024-11-28T10:12:49Z

ci:forward

liferay-continuous-integration · 2024-11-28T10:12:55Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2024-11-28T10:12:56Z

Skipping previously passed test suites:

ci:test:sf

liferay-continuous-integration · 2024-11-28T11:10:14Z

✔️ ci:test:stable - 24 out of 24 jobs passed

✔️ ci:test:relevant - 33 out of 33 jobs passed in 57 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d71b1f9b8213c734d0eca46f7ca2f0c6e6ecbc45

Upstream Comparison:

Branch GIT ID: d71b1f9b8213c734d0eca46f7ca2f0c6e6ecbc45
Jenkins Build URL: EE Development Acceptance (master) - 1050 - 2024-11-27[16:41:25]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

central-requirements
- central-requirements/0/0
functional-smoke-tomcat90-mysql57_stable
- functional-smoke-tomcat90-mysql57_stable/0/0
functional-upgrade-tomcat90-mysql57_stable
js-unit
- js-unit/0/0
- js-unit/1/0
modules-compile
modules-integration-mysql57_stable
- modules-integration-mysql57_stable/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-js-tomcat90-mysql57_stable
- playwright-js-tomcat90-mysql57_stable/0/0
unit_stable
- unit_stable/0/0

ci:test:relevant - 33 out of 33 jobs PASSED

33 Successful Jobs:

test-portal-acceptance-pullrequest(master)
central-requirements
- central-requirements/0/0
functional-smoke-tomcat90-mysql57_stable
- functional-smoke-tomcat90-mysql57_stable/0/0
functional-upgrade-tomcat90-mysql57_stable
js-unit
- js-unit/0/0
- js-unit/1/0
modules-compile
modules-integration-mysql57
- modules-integration-mysql57/0/0
modules-integration-mysql57_stable
- modules-integration-mysql57_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- modules-unit/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-js-tomcat90-mysql57
playwright-js-tomcat90-mysql57_stable
- playwright-js-tomcat90-mysql57_stable/0/0
unit_stable
- unit_stable/0/0

For more details click here.

liferay-continuous-integration · 2024-11-28T11:12:04Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2024-11-28T11:12:31Z

Pull request has been successfully forwarded to brianchandotcom#156549
Console

liferay-continuous-integration · 2024-11-28T11:16:28Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#11972

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-content-management#6133

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - jkappler > liferay-content-management - PR#6133 - 2024-11-28[02:12:59]

Testray Build ID:79915222

Testray Importer:publish-testray-report#26114

jkappler requested a review from liferay-content-management as a code owner November 28, 2024 08:56

liferay-content-management added the 🔍 backend review needed label Nov 28, 2024

jkappler requested a review from adolfopa November 28, 2024 08:58

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Nov 28, 2024

jkappler added 8 commits November 28, 2024 10:20

LPD-42706 Create new display context with method to retrieve the modi…

eaa2eb0

…fied label based on a message

LPD-42706 Apply usage

6dfbd21

LPD-42706 Add unit test

716e82f

LPD-42706 Announcement entry doesn't have status by username, so show…

5aac178

… only when the entry was modified to avoid confusion

LPD-42706 Repository entry doesn't have status by username, so show o…

b84cf5f

…nly when the entry was modified to avoid confusion

LPD-42706 Folder doesn't have status by username, so show only when t…

eab8767

…he entry was modified to avoid confusion

LPD-42706 Show only when the folder was modified to avoid confusion

36b8e41

LPD-42706 KBTemplate doesn't have status by username, so show only wh…

7536f5a

…en the entry was modified to avoid confusion

jkappler force-pushed the LPD-42706_message branch from d53fff7 to 7536f5a Compare November 28, 2024 09:21

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Nov 28, 2024

adolfopa approved these changes Nov 28, 2024

View reviewed changes

liferay-content-management added ⚠ missing tests ✅ ready to forward labels Nov 28, 2024

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 28, 2024

liferay-continuous-integration closed this Nov 28, 2024

liferay-continuous-integration mentioned this pull request Nov 28, 2024

LPD-42706 brianchandotcom/liferay-portal#156549

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPD-42706 #6133

LPD-42706 #6133

jkappler commented Nov 28, 2024 •

edited

Loading

liferay-continuous-integration commented Nov 28, 2024

jkappler commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

jkappler commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

adolfopa commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

LPD-42706 #6133

LPD-42706 #6133

Conversation

jkappler commented Nov 28, 2024 • edited Loading

What is this trying to solve?

How am I fixing it?

liferay-continuous-integration commented Nov 28, 2024

jkappler commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

❌ ci:test:sf - 0 out of 1 jobs passed in 10 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

jkappler commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

adolfopa commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

✔️ ci:test:stable - 24 out of 24 jobs passed

✔️ ci:test:relevant - 33 out of 33 jobs passed in 57 minutes

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

liferay-continuous-integration commented Nov 28, 2024

jkappler commented Nov 28, 2024 •

edited

Loading