[improve][broker] Optimize Consumer.individualAck to avoid multiple call pendingAck to find acked consumer. #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current broker logic of individualAck will try to locate position and which consumer is the acked message owner.
but the logic is not shared the information which will call this find logic multiple times.
eg. foreach ack messge:
if the message is own by other consumers, and if consumer within one subscription is huge the performance is very low.
Modifications
just call one time find logic. and return the origin LongPair to extract information.
when the following logic try to use the pos and owner information. just pass the find owner consumer.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: