Skip to content

Commit

Permalink
Fix issue with genomics list-tests options
Browse files Browse the repository at this point in the history
  • Loading branch information
mschroering committed Nov 20, 2020
1 parent 70e3898 commit 1a4507f
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [12.1.1] - 2020-11-20

### Fixed

- Fixed the `genomics list-tests` command to list tests by project using the `--limit` option.


## [12.1.0] - 2020-11-03

### Changed
Expand Down Expand Up @@ -815,6 +822,7 @@ and `create-nantomics-vcf-import`

- Replaced the `defaults` command with a `setup` command

[12.1.1]: https://github.com/lifeomic/cli/compare/v12.1.0...v12.1.1
[12.1.0]: https://github.com/lifeomic/cli/compare/v12.0.0...v12.1.0
[12.0.0]: https://github.com/lifeomic/cli/compare/v11.9.0...v12.0.0
[11.9.0]: https://github.com/lifeomic/cli/compare/v11.8.1...v11.9.0
Expand Down Expand Up @@ -910,4 +918,4 @@ and `create-nantomics-vcf-import`
[5.2.1]: https://github.com/lifeomic/cli/compare/v5.2.0...v5.2.1
[5.2.0]: https://github.com/lifeomic/cli/compare/v5.1.0...v5.2.0
[5.1.0]: https://github.com/lifeomic/cli/compare/5.0.0...v5.1.0
[5.0.0]: https://github.com/lifeomic/cli/compare/v4.0.0...5.0.0
[5.0.0]: https://github.com/lifeomic/cli/compare/v4.0.0...5.0.0
12 changes: 6 additions & 6 deletions lib/cmds/genomics_cmds/list-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@ exports.builder = yargs => {
}).positional('subjectId', {
describe: 'The subject ID.',
type: 'string'
}).option('page-size (only used when listing by project)', {
describe: 'The page size',
}).option('page-size', {
describe: 'The page size (only used when listing by project)',
type: 'number',
alias: 'n',
default: 25
}).option('next-page-token (only used when listing by project)', {
describe: 'Next page token',
}).option('next-page-token', {
describe: 'Next page token (only used when listing by project)',
alias: 't',
type: 'string'
}).option('limit (only used when listing by project)', {
describe: 'The maximum number of items to return',
}).option('limit', {
describe: 'The maximum number of items to return (only used when listing by project)',
alias: 'l',
type: 'number'
}).option('status', {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/commands/genomics-tests.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ test.serial.cb('The "list-tests" command should list tests for a project', t =>
getStub.onFirstCall().returns(res);
callback = () => {
t.is(getStub.callCount, 1);
t.is(getStub.getCall(0).args[1], '/v1/genomics/projects/project1/tests?pageSize=&nextPageToken=');
t.is(getStub.getCall(0).args[1], '/v1/genomics/projects/project1/tests?pageSize=25&nextPageToken=');
t.is(printSpy.callCount, 1);
t.deepEqual(printSpy.getCall(0).args[0], { items: [] });
t.end();
Expand Down

0 comments on commit 1a4507f

Please sign in to comment.