Add methods for manual flushing and changing write offset #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use case - generating fragmented MP4s for HLS streaming requires creating an initialization segment with decoder-specific config (the moov box). Manual flush allows writing out the moov box before adding samples. Similar with write offset - after writing the moov box, one wants to write media segments that begin with a moof box and have 1 or more mdat boxes. This adds a method for overwriting the write offset, in case the library user wants to treat MP4E_mux_t as an opaque type.
|
Realized I broke some compatibility by never updating the fragments count - pushed an update to increment it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case - generating fragmented MP4s for HLS streaming requires
creating an initialization segment with decoder-specific config
(the moov box). Manual flush allows writing out the moov box
before adding samples.
Similar with write offset - after writing the moov box, one wants
to write media segments that begin with a moof box and have 1 or more
mdat boxes. This adds a method for overwriting the write offset,
in case the library user wants to treat MP4E_mux_t as an opaque type.