Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Packed Relocations #991

Closed
wants to merge 1 commit into from
Closed

Android Packed Relocations #991

wants to merge 1 commit into from

Conversation

sebadur
Copy link

@sebadur sebadur commented Nov 2, 2023

Based on issue #111 and the parser from your own branch android-packed-relocations, this is a proposal to add support for the Android Packed Relocations types DT_ANDROID_REL[A] and DT_RELR. It references from the lld linker from llvm project.

open tasks:

  • fair amount of testing
  • why non-relative-relocation groups don't have the has_addend_if_rela flag in lld? It is implemented differently here
  • maybe add support for multiple .relr.dyn sections

@romainthomas
Copy link
Member

Thank you very much @sebadur for these updates. I'll see how to integrate these changes with the current design update I'm working on.

romainthomas added a commit that referenced this pull request Feb 3, 2024
@romainthomas
Add support for DT_RELR/DT_ANDROID_RELA relocations
00e4a68 
This commit adds the support for the (new) relative relocations
as well as the Android packed relocation format.

Resolve: #111 #991
@romainthomas
Copy link
Member

Integrated with 00e4a68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebadur @romainthomas