MachO::Binary: treat all sections in the same way during shift #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I welcome a test case that ensures we don't regress this fix. |
Previously there were exceptions for zerofill sections because offset checks were not correct. After fixing checks for offsets/va, special handling of zerofill sections is no longer needed.
DzenIsRich
force-pushed
the
zmpr-macho-thread-local-zerofill
branch
from
544ab8d to
5c8604a
Compare
DzenIsRich
changed the title
|
It is not trivial to craft a test case that reproduces the problem on main branch. I can reproduce the problem with proprietary binary that I cannot share, but it's difficult to minimize it. Can we proceed without tests? |
|
Ok I trust you on this. I'll see if I can find a testcase on my end. |
romainthomas
pushed a commit
that referenced
this pull request
Dec 23, 2024
Previously there were exceptions for zerofill sections because offset checks were not correct. After fixing checks for offsets/va, special handling of zerofill sections is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.