Resolve #976

lief-project · Oct 7, 2023 · d5dc7fd · d5dc7fd
1 parent d7b962d
commit d5dc7fd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Abstract/Section.cpp b/src/Abstract/Section.cpp
@@ -179,7 +179,7 @@ std::vector<size_t> Section::search_all(const std::string& v) const {
 double Section::entropy() const {
   std::array<uint64_t, 256> frequencies = { {0} };
   span<const uint8_t> content = this->content();
-  if (content.empty()) {
+  if (content.empty() || content.size() == 1) {
     return 0.;
   }
   for (uint8_t x : content) {

diff --git a/tests/abstract/test_abstract.py b/tests/abstract/test_abstract.py
@@ -93,3 +93,15 @@ def test_function():
     assert binary.get_function_address("foo") == lief.lief_errors.not_found
     assert binary.get_function_address("add") == 0x6a0
 
+
+def test_entropy():
+    """
+    from issue #976 by @PaulDance
+    """
+    weird_section_0 = lief.MachO.Section("weird_section_0", []).entropy
+    weird_section_1 = lief.MachO.Section("weird_section_1", [1]).entropy
+    assert str(weird_section_0) == "0.0"
+    assert str(weird_section_1) == "0.0"
+
+    assert weird_section_0 >= 0
+    assert weird_section_1 >= 0